A CPT named 'code' triggers wierd font/order bugs in admin

[clarklab]

When you make a custom post type named 'code', some weird problems arise. In the admin, the post list is rendered in Consalas (see attachment). Even weirder, the default sort changes to alpha order, not date.

The font looks to be happening because the class 'code' gets added to the TR in the post list, but I'm not sure why the order would change.

I checked for a reserved CPT name, but all the codex said was to avoid the wp_ prefix.

[clarklab]

the post listing rendered in the wrong font.

[c3mdigital]

Was not able to reproduce sort order but confirmed font changing. Is the .code css class used anywhere in admin?

[helenyhou]

Replying to c3mdigital:

Is the .code css class used anywhere in admin?

Yes - quite a few places. Things like inputs, especially those containing code or URL entry, and some lists (files to delete, etc.).

[c3mdigital]

Replying to helenyhou:

Replying to c3mdigital:

Is the .code css class used anywhere in admin?

Yes - quite a few places. Things like inputs, especially those containing code or URL entry, and some lists (files to delete, etc.).

Just did a search and found around 20 uses so removing .code from css is not an option.

[scribu]

I assume the issue here is that there's some css class being generated based on the post type name.

We should prefix that class, to avoid collisions. Example: class="cpt-<?php echo $post_type; ?>".

[SergeyBiryukov]

Related: #18974

[c3mdigital]

Replying to scribu:

I assume the issue here is that there's some css class being generated based on the post type name.

We should prefix that class, to avoid collisions. Example: class="cpt-<?php echo $post_type; ?>".

Makes sense but would require changing get_post_class:

        $classes[] = 'post-' . $post->ID;  
	$classes[] = $post->post_type;  
	$classes[] = 'type-' . $post->post_type;  
	$classes[] = 'status-' . $post->post_status;  

Might break some themes.

[nacin]

$classes[] = $post->post_type; — introduced in [8641]. We can solve this for the admin by putting an is_admin() around that single class.

[c3mdigital]

Wraps post type in in is_admin

[nacin]

In [21848]:

Don't output the {$post_type} post class in the admin, to avoid clashes with admin CSS. props c3mdigital. fixes #21203.