WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #21212, comment 37


Ignore:
Timestamp:
11/20/2014 05:57:23 PM (6 years ago)
Author:
mnelson4
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21212, comment 37

    initial v1  
    11Setting `STRICT_ALL_TABLES` means that queries that were passing before [30400] are now failing, even when WP_DEBUG is set to OFF.
    22
    3 I think the idea of making the MySQL modes filterable, so plugin or theme authors can choose to disable `STRICT_ALL_TABLES` is good, but I agree with @nerrad: this will come as a surprise to plugin or theme developers, and even if they do put out a quick update to their plugin or theme, many of their users may update wordpress core before they update the affected plugins or themes.
     3I think the idea of making the MySQL modes filterable, so plugin or theme authors can choose to disable `STRICT_ALL_TABLES` is good, but I agree with @nerrad: this will come as a surprise to plugin or theme developers, and even if they do put out a quick update to their plugin or theme (which might be as simple as using that filter to disable `STRICT_ALL_TABLES`), many of their users may update wordpress core before they update the affected plugins or themes.
    44
    55If we're going to be setting `STRICT_ALL_TABLES` as a mode in 4.1, I'd suggest it just be the default when WP_DEBUG is on. That way affected plugins and themes will be made aware soon, but it won't affect users live installs.