WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#21214 closed enhancement (wontfix)

Update the keyboard shortcuts in TinyMCE

Reported by: azaozz Owned by: azaozz
Milestone: Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch needs-refresh
Focuses: Cc:

Description

As the title. Since these shortcuts were added, the API has changed a bit and the browsers have changed even more.

Attachments (1)

21214.patch (21.0 KB) - added by azaozz 7 years ago.

Download all attachments as: .zip

Change History (11)

#1 @azaozz
7 years ago

Related: #21197, #17992.

@azaozz
7 years ago

#2 @azaozz
7 years ago

21214.patch changes the shortcuts in Firefox, Chrome and Safari (Mac and Windows) to Alt + letter, but keeps them to Alt + Shift + letter in IE and Opera (as Alt + letter are used in the browsers already). It also adds new shortcut for DFW mode: Alt + W.

#3 @azaozz
7 years ago

In [21266]:

TinyMCE: update the keyboard shortcuts: Alt + letter for Firefox and WebKit, Alt + Shift + letter for IE and Opera, add shortcut for DFW (Alt + W), see #21214, fixes #21197, fixes #17992

#4 @azaozz
7 years ago

Lets test these. Leaving the ticket open for suggestions for the "tooltips" on the buttons or the Help in TinyMCE.

#5 @nacin
7 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

Just now seeing this. What's the reasoning behind the changes here? Changing keyboard shortcuts is lame because it destroys anyone's muscle memory, so it'd be good to make sure.

That whole About dialog could use a refresh. We should show users only the shortcuts that make sense for their system. We shouldn't need to tell people to pair "Control" (or "Command") with a table of keys. Because once you get to another table of keys with different modifier keys, you have to keep going back to refer to what the modifier keys are for the shortcut you are looking at.

#6 @azaozz
7 years ago

  • Milestone changed from 3.5 to Future Release

The mod keys change for Firefox in the above patch was disabled in [21415]. It interferes with some keyboard drivers for some languages on Windows as they use left Alt and right Alt differently.

Yeah, best would be to update the Help/About popup for the visual editor. Regarding keyboard shortcuts in TinyMCE, this ticket is dependent on the changes proposed in #21414.

#7 follow-up: @nacin
7 years ago

  • Milestone changed from Future Release to 3.5

#21414 doesn't really make any sense. We're going to force people to enable shortcuts to use something like Ctrl/Cmd + B for bold? Or are we just referring to the bottom group of shortcuts?

Can we at least change "The following shortcuts use different access keys: Alt + letter in Firefox, Chrome and Safari, Alt + Shift + letter in Internet Explorer and Opera." to just showing the shortcut for whatever browser is being used?

#8 in reply to: ↑ 7 @azaozz
7 years ago

Replying to nacin:

...We're going to force people to enable shortcuts to use something like Ctrl/Cmd + B for bold? Or are we just referring to the bottom group of shortcuts?

Right, that would affect only the custom shortcuts added in the 'wordpress' plugin for TinyMCE, not the default editor or OS shortcuts.

Can we at least change "The following shortcuts use different access keys: Alt + letter in Firefox, Chrome and Safari, Alt + Shift + letter in Internet Explorer and Opera." to just showing the shortcut for whatever browser is being used?

Sure, sounds good.

#9 @wonderboymusic
7 years ago

  • Keywords has-patch needs-refresh added

#10 @azaozz
7 years ago

  • Milestone 3.5 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Unfortunately there aren't that many "free" key combinations left for custom shortcuts. Nearly all are already used by the browsers and the OS. Closing this in favour of #21414.

Note: See TracTickets for help on using tickets.