Inconsistent font size in Network Admin > Site Users screen

[PeteMall]

"Add Existing User" and "Add New User" are <h5> and the text size is smaller than the body copy.

[obenland]

Bump heading levels one up

[nacin]

We already use <h3>'s for the Sites/Themes/Info/Settings tabs, which is why <h4> and then <h5> was chosen. What if we just killed off the preamble and current <h4> and bumped the h5's up, so remove:

"Add User to This Site

You may add from existing network users, or set up a new user to add to this site."

Seems kind of redundant to have such hierarchy on the page.

[obenland]

I'm glad to hear that. I thought the same when I prepared the patch!

[helenyhou]

Result:

Looks okay - would like spacing cleaned up, especially around the buttons, and then should be good to go in.

[obenland]

21223.3.diff​ adds the default paragraph tag wrap for the buttons and moves from a custom implementation to using selected() in the dropdowns.

Apart from the buttons, regular settings markup is used. Anything in particular that needs further attention, Helen?

[lessbloat]

Replying to obenland:

Anything in particular that needs further attention

Naw, this looks fine now. In @helenyhou's screenshot, the "Username and password..." line was sitting right on top of the button. 21223.3.diff appears to fix this. :-)

[helenyhou]

21223.3.diff​ looks good. Noticed that the patch does a couple other things: coding standards and use of selected().

[nacin]

​http://cl.ly/image/3W0I2l3K3N1q

Two things:

1. There's much more spacing between these forms than there is between the top form and the list table.

2. It's a bit odd that h3's appear smaller than the buttons themselves. Since this is a form within an h3, perhaps these should be .button-small buttons? It's not like you're submitting the entire page (under an h2) as you would be on a standard Settings screen.

[helenyhou]

Replying to nacin:

1. There's much more spacing between these forms than there is between the top form and the list table.

Indeed. Should be the other way around.

2. It's a bit odd that h3's appear smaller than the buttons themselves.

It seems like we should make the regular/default button size the small/short one instead over on #21598.

[nacin]

In [21854]:

Simplify the markup and hierarchy of the Add Existing and Add New user forms on site-users.php. props obenland, fixes #21223.