WordPress.org

Make WordPress Core

#21223 closed defect (bug) (fixed)

Inconsistent font size in Network Admin > Site Users screen

Reported by: PeteMall Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description (last modified by PeteMall)

"Add Existing User" and "Add New User" are <h5> and the text size is smaller than the body copy.

http://s.ran.ge/0k0c2v15202S3o2b0A3G/Screen%20Shot%202012-07-11%20at%204.25.13%20PM.png

Attachments (4)

21223.diff (1.7 KB) - added by obenland 22 months ago.
Bump heading levels one up
21223.2.diff (1.6 KB) - added by obenland 22 months ago.
Screen Shot 2012-08-21 at 3.16.57 PM.png (28.1 KB) - added by helenyhou 20 months ago.
21223.3.diff (3.9 KB) - added by obenland 20 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 PeteMall22 months ago

  • Description modified (diff)

obenland22 months ago

Bump heading levels one up

comment:2 obenland22 months ago

  • Keywords has-patch ui-feedback added; needs-patch removed

comment:3 nacin22 months ago

We already use <h3>'s for the Sites/Themes/Info/Settings tabs, which is why <h4> and then <h5> was chosen. What if we just killed off the preamble and current <h4> and bumped the h5's up, so remove:

"Add User to This Site

You may add from existing network users, or set up a new user to add to this site."

Seems kind of redundant to have such hierarchy on the page.

comment:4 obenland22 months ago

I'm glad to hear that. I thought the same when I prepared the patch!

obenland22 months ago

comment:5 helenyhou20 months ago

  • Keywords ui-feedback removed

Result:

http://core.trac.wordpress.org/raw-attachment/ticket/21223/Screen%20Shot%202012-08-21%20at%203.16.57%20PM.png

Looks okay - would like spacing cleaned up, especially around the buttons, and then should be good to go in.

obenland20 months ago

comment:6 follow-up: obenland20 months ago

21223.3.diff adds the default paragraph tag wrap for the buttons and moves from a custom implementation to using selected() in the dropdowns.

Apart from the buttons, regular settings markup is used. Anything in particular that needs further attention, Helen?

comment:7 in reply to: ↑ 6 lessbloat20 months ago

  • Keywords needs-ui removed

Replying to obenland:

Anything in particular that needs further attention

Naw, this looks fine now. In @helenyhou's screenshot, the "Username and password..." line was sitting right on top of the button. 21223.3.diff appears to fix this. :-)

Last edited 20 months ago by lessbloat (previous) (diff)

comment:8 helenyhou20 months ago

  • Keywords commit added

21223.3.diff looks good. Noticed that the patch does a couple other things: coding standards and use of selected().

comment:9 follow-up: nacin19 months ago

http://cl.ly/image/3W0I2l3K3N1q

Two things:

  1. There's much more spacing between these forms than there is between the top form and the list table.
  1. It's a bit odd that h3's appear smaller than the buttons themselves. Since this is a form within an h3, perhaps these should be .button-small buttons? It's not like you're submitting the entire page (under an h2) as you would be on a standard Settings screen.

comment:10 in reply to: ↑ 9 helenyhou19 months ago

Replying to nacin:

  1. There's much more spacing between these forms than there is between the top form and the list table.

Indeed. Should be the other way around.

  1. It's a bit odd that h3's appear smaller than the buttons themselves.

It seems like we should make the regular/default button size the small/short one instead over on #21598.

comment:11 nacin19 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21854]:

Simplify the markup and hierarchy of the Add Existing and Add New user forms on site-users.php. props obenland, fixes #21223.

Note: See TracTickets for help on using tickets.