WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#21226 closed enhancement (fixed)

Twenty Twelve: Default to a gray background color

Reported by: nacin Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

The plain white slate is nice, but the default gray color of #e6e6e6 on http://twentytwelvedemo.wordpress.com/ really makes the theme stand out as "whoa." I think this should be the default.

Attachments (2)

21226.diff (2.3 KB) - added by lancewillett 8 years ago.
Make default color #e6e6e6 and handle both white and empty cases
21226.2.diff (2.3 KB) - added by SergeyBiryukov 8 years ago.
Minor edit (fixed whitespace in line 75)

Download all attachments as: .zip

Change History (18)

#1 @drewstrojny
8 years ago

  • Cc dstrojny@… added

#3 @lancewillett
8 years ago

  • Cc lancewillett added

#4 @drewstrojny
8 years ago

I too like the gray background better than plain white, but I worry about this. Mainly because it's super easy to add a custom background, but not so easy to take it away. Therefore, a user who actually wants a white background will have trouble achieving that goal. I guess we could hack something in for the white background case, but that seems, well, hacky :)

#5 @lancewillett
8 years ago

We can do this pretty easily. Set body bg color to gray, then in the stylesheet set the shadowing and extra spacing as the default. Then, add a body_class value for the white bg color if it exists, and in CSS account for that by removing the spacing and shadow.

@lancewillett
8 years ago

Make default color #e6e6e6 and handle both white and empty cases

#6 @lancewillett
8 years ago

I'm attaching a patch so you can play with it.

#7 @drewstrojny
8 years ago

Replying to lancewillett:

We can do this pretty easily. Set body bg color to gray, then in the stylesheet set the shadowing and extra spacing as the default. Then, add a body_class value for the white bg color if it exists, and in CSS account for that by removing the spacing and shadow.

I think that would be a workable solution, but it just seems backwards to me, especially for a developer. It's kind of like giving someone a new car with a bumper sticker on it. Yeah, they can peel it off, but it's a bit of a pain.

I would think the background color / image as a progressive enhancement of sorts is an easier starting point for developers. More of a blank slate if you will. This is especially true for a default theme, where a blank slate adds significant value. If it were a commercial or niche theme, it wouldn't be as important.

#8 @lancewillett
8 years ago

  • Keywords 2nd-opinion added

Can other folks chime in? What do you think is a nicer first-run look and feel? Better to have it be clean slate to build from, or feel more "set up" a certain way that you have to then undo.

#9 @helenyhou
8 years ago

I think it's nicer to have the background color on first run. It was actually very confusing for me to see the demo site and then have the initial install of the theme not look anything like it at all because the spacing and box shadow are rather different. Doesn't feel like a clean slate so much as a different slate at the moment.

#10 @lancewillett
8 years ago

  • Cc drewstrojny added; dstrojny@… removed

@SergeyBiryukov
8 years ago

Minor edit (fixed whitespace in line 75)

#11 @SergeyBiryukov
8 years ago

I think I'd prefer having the background color on the first run. Looks cleaner and less confusing as to why it's not like on the demo site.

#12 @obenland
8 years ago

  • Cc konstantin@… added

#13 follow-up: @nacin
8 years ago

I agree with gray by default. Not for the demo site (which no one will see) but because it is simply a better design. If you wanted a "clean slate" as a developer, you should use _s, toolbox, or sandbox.

Getting 21226.diff to work in the customizer via postMessage would be gravy.

#14 @lancewillett
8 years ago

In [21325]:

Twenty Twelve: set gray background as default, handling empty and white as fallback cases. See #21226.

Also fix incorrect logic for full-width-page.php page template check in twentytwelve_body_class function.

#15 in reply to: ↑ 13 @lancewillett
8 years ago

  • Keywords 2nd-opinion removed

Replying to nacin:

Getting 21226.diff to work in the customizer via postMessage would be gravy.

Leaving this ticket open to work on the Theme Customizer integration. Changing the background color should change the body_class value there and update the spacing immediately.

#16 @lancewillett
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [21343] Twenty Twelve: enable async body class value changes for custom background color changes in Theme Customizer. See #21226.

Closing as fixed, we can open new tickets for new issues relating to Theme Customizer as needed.

Note: See TracTickets for help on using tickets.