WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 4 months ago

#21234 new defect (bug)

Recursive directory creation & get_calendar() for custom post types

Reported by: avaddon Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4.1
Component: Posts, Post Types Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

Hello!
I made two patches, and sent the pull request on githab.

https://github.com/WordPress/WordPress/pull/12
https://github.com/WordPress/WordPress/pull/14

And I want to join to contributers team. How can I do it?
Irc chanel is Terminated :(

Change History (5)

#1 @ocean90
7 years ago

  • Keywords has-patch removed

Please provide SVN patches and create for each issue one ticket.

Also there is no real contributor team, with creating patches (which will be commited if they are good) you are a contributor.

#3 @dd32
7 years ago

See this codex page for a list of the IRC channels.

The patch in the above Github link mixes up what the code is actually doing:

$dir_perms = $stat['mode'] & 0007777;

vs

 @mkdir( $target, 0777, true )

The latter creates a direcotory wth 777 permissions, the first copies the parents permissions to the child (the 7777 is limiting it to a specific set of permissions).

It can indeed be made simpler however, The permission logic can be pulled out and moved to before the mkdir() call is ever made. Unfortunately, Error suppression is needed for cases where the function emits uncatchable warnings (PHP Safe mode IIRC)

#4 @nacin
6 years ago

  • Component changed from General to Post Types

#5 @chriscct7
4 years ago

  • Keywords needs-patch added
Note: See TracTickets for help on using tickets.