WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 5 months ago

Last modified 4 months ago

#21236 closed defect (bug) (worksforme)

Network Admin broken link http// not http:// typo if siteadmin changes siteurl of subsite

Reported by: damiensaunders Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.4.1
Component: Network Admin Keywords: reporter-feedback
Focuses: multisite Cc:

Description

Given:

  • a multisite install at example.org configured for sub-domains
  • a subsite called "foo" at foo.example.org
  • a domain mapping foo.com -> foo.example.org
  • www.foo.com set as PRIMARY domain for that blog

and...
the siteadmin changes the siteurl for that blog via Network Admin > Settings > Site

then ...
when the siteadmin visits foo.com/wp-admin the the menu link for Network admin is broken.

It's expected that the link looks like

example.org/wp-admin/network/

but instead it is changed to

http//example.org/wp-admin/network/


Clicking on the link resolves to a 404 page.

This maybe trivial but changing the siteurl for mapped domains / subsites is important if you need to integrate with 3rd party API like google checkout which expect qualified valid full domain.

I've noticed on the multisite forums that a few other users have complained about the network admin link being broken.

If you need screenshots please let me know

Attachments (1)

Network Admin URL http error.JPG (214.1 KB) - added by damiensaunders 22 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 wpmuguru22 months ago

I'm able to edit a site url without any issue in Network admin in version 3.4.1.

The point of the domain mapping plugin is that it allows you to map the site to a domain without/instead of editing the site in Network admin.

If you have to edit the site url to get the domain mapped URL to work then you have something wrong in your install/configuration.

comment:2 damiensaunders22 months ago

Hi there

I think the domain mapping plugin is not related to this issue (it's just my current setup). But its really hard to do this on a dev box if you can't fake all the full-domains

This is very trivial but it affects the siteadmin user experience ... if you change the siteurl for a sub-site to a fully qualified domain ... then the link to Network Admin (from that subsite) is broken as the link shows as

http//

not

http://


I've attached a screenshot for your records ... note the URL in the bottom left of the chrome status bar

If the link works for you then im happy to close this

Cheers

Damien

Last edited 22 months ago by damiensaunders (previous) (diff)

comment:3 nacin19 months ago

  • Keywords reporter-feedback added

Still an issue?

comment:4 Ipstenu5 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

Seems to be fine now. I changed foo.localhost.dev to foolocal.dev and all the URLs were fine.

Not that you should be changing the siteurl for a sub-site to a fully qualified domain anyway, but you CAN as of 3.8 trunk.

comment:5 markoheijnen4 months ago

  • Milestone Awaiting Review deleted

Clearing out the milestones for closed tickets on Awaiting Review

Note: See TracTickets for help on using tickets.