Twenty Twelve: Sticky badge on single view

[obenland]

In Twenty Twelve the sticky badge is broken on single view.

It should either be removed entirely or fixed via CSS. The bug didn't occur in Twenty Eleven because a content-single.php template was available.

[obenland]

Broken badge

[obenland]

Don't show if is single

[DrewAPicture]

Per ​discussion in IRC:

In archives, it looks like the sticky post_class isn't being applied because is_home() && ! is_paged() aren't true (per post-template.php). There's some funkiness with .featured-post because of this this:

Index looks like this: ​http://cl.ly/3K0e2C192L453N3G1q0b

Archive: ​http://cl.ly/1T0d3W051C022N0W3D2S

[DrewAPicture]

Incrememntal, adds is_archive check in content.php

[obenland]

Lets make our lives a little easier and only check for is_home

[DrewAPicture]

Lets make our lives a little easier and only check for is_home

If you're going to go that route, you might as well just mirror the checks in post-template.php by adding ! is_paged(). There are very valid reasons you might want to highlight Featured/sticky posts outside the homepage. And besides, the lack of 'sticky' post class was the issue on archives anyway. :)

[lancewillett]

Correct, the sticky "featured post" badge should only apply on the home page, when not paged.

[lancewillett]

In [21263]:

Twenty Twelve: show sticky badge only on non-paged home view. Fixes #21238, props DrewAPicture and obenland.

[lancewillett]

Replying to nacin:

Nacin, something left to fix?

[nacin]

I don't really like [21263]. <article> uses post_class() which means it will receive the .sticky class if is_sticky() && is_home() && ! is_paged(). If we can make this markup redundant, then this conditional is also redundant. I would rather rely on the existing classes than creating a new div and our own class.

[lancewillett]

Replying to nacin:

I don't really like [21263]. <article> uses post_class() which means it will receive the .sticky class if is_sticky() && is_home() && ! is_paged().

Chatted about this in #wordpress-dev IRC channel today, and agreed on keeping the conditional here as the solution isn't just a style hook where the post_class would be sufficient.

nacin: lancewillett: let me know if my comment on #21238 doesn't make sense
nacin: lancewillett: looking at the code, it doesn't look like it makes sense
lancewillett: I don't think we can use a post_class value to hide the extra markup
nacin: I thought the conditional was about styling, not about an extra piece of markup.
lancewillett: Some kind of logic is needed to add it in
lancewillett: Right, exactly