move password hint text to a function

[convissor]

The password hint text, noted below, is hard coded in four places:

wp-admin/install.php
wp-admin/user-edit.php
wp-admin/user-new.php
wp-login.php

Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers and symbols like ! " ? $ % ^ & ).

This approach is prone to mistakes when changes are made. In addition, plugins that want to override the text need to use the resource intensive and clumsy gettext filter.

Per nacin and westi, the attached patch moves the text to a function (wp_password_hint()) in wp-includes/user.php and adds a filter (password_hint).

[SergeyBiryukov]

It would probably make sense to mark the function as private (21243.2.diff​), similarly to _wp_get_user_contactmethods().

[ramiy]

I like this.
Simple function and it has filterable text.

[voldemortensen]

+1 for this. Refreshed patch.

[convissor]

clean, patch updated to 4.1

[convissor]

The minor grammar change in #26457 / r27246 "breaking" ​Login Security Solution reaffirms the need for this patch.

[SergeyBiryukov]

The filter needs to be documented as per the ​documentation standards.

[convissor]

Add docblock for filter hook call. Fix @since on main function.

[SergeyBiryukov]

In 29962:

Move password hint text to a function. Add 'password_hint' filter.

props convissor.
fixes #21243.

[SergeyBiryukov]

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

[Ankit K Gupta]

Updated the function name for make consistency with other functions.

[Ankit K Gupta]

patch file with updated function name

[Ankit K Gupta]

Patch file with formatting

[ramiy]

Replying to SergeyBiryukov:

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

Sergey,

why not use a shorter name _get_password_hint() ?

[Ankit K Gupta]

Replying to ramiy:

Replying to SergeyBiryukov:

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

Sergey,

why not use a shorter name _get_password_hint() ?

We can use this. It is based on our choice. Let me know, what is the issue with longer name of the function ?

[johnbillion]

In 30033:

Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.

[Ankit K Gupta]

Replying to johnbillion:

In 30033:

Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.

Did you add my patch file ? As attached in comment 10 Or any issue in my patch file ?

Please confirm.
Thanks !

[johnbillion]

I'm not sure what you're asking, Ankit. The change was applied in r30033 and will be available in WordPress 4.1.

[johnbillion]

Ah I see. The function was renamed _wp_get_password_hint() to bring it inline with other core function names.

[Ankit K Gupta]

I guess, You forgot to mention the Props in this ticket after commit my patch.

[helen]

Replying to Ankit K Gupta:

I guess, You forgot to mention the Props in this ticket after commit my patch.

Just uploading a patch doesn't trigger any notifications - it is very likely johnbillion made the changes himself and committed them, as opposed to applying a patch that wasn't seen. In the future, please leave a comment about your patch, which also helps to explain what you're doing with it.

[johnbillion]

Nope I just missed the props. Sorry Ankit!

[Ankit K Gupta]

Replying to johnbillion:

Nope I just missed the props. Sorry Ankit!

Hey johnbillion. It's fine.
It would be great if you can add props now. Otherwise it's ok.

[Ankit K Gupta]

Replying to johnbillion:

Nope I just missed the props. Sorry Ankit!

It would be great if you can add props now.?

[SergeyBiryukov]

Sorry, we can't change the commit message after the fact.

But you'll still make it to the Credits screen with [30027] and [30054].

[Ankit K Gupta]

Replying to SergeyBiryukov:

Sorry, we can't change the commit message after the fact.

But you'll still make it to the Credits screen with [30027] and [30054].

It's fine.
Thanks for the response.

[SergeyBiryukov]

In 30940:

No need for wp_get_password_hint() to be prefixed as if it is private.

Merges [30855] to the 4.1 branch.

props nacin.
see #21243.