Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21254 closed defect (bug) (fixed)

Twenty Twelve: Full width when sidebar is not populated

Reported by: obenland's profile obenland Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When there is no sidebar, full width styles currently do not get applied to #content.

Attachments (1)

21254.diff (2.0 KB) - added by obenland 12 years ago.

Download all attachments as: .zip

Change History (5)

@obenland
12 years ago

#1 follow-up: @obenland
12 years ago

21254.diff Adds .full-width to style declaration, removes a redundant page template check and adds the case of having no sidebar to the $content_width conditional.

#2 @ocean90
12 years ago

  • Component changed from General to Bundled Theme
  • Milestone changed from Awaiting Review to 3.5

#3 in reply to: ↑ 1 @lancewillett
12 years ago

Replying to obenland:

21254.diff Adds .full-width to style declaration, removes a redundant page template check and adds the case of having no sidebar to the $content_width conditional.

Patch looks good, thanks much. One comment is we *might* want the 'full-width' class on the full-width page also, in case we decide to hook in more styles later.

#4 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21279]:

Twenty Twelve: Update full-width handling with a missing CSS selector, and add case of no sidebar to the content_width calculation. Props obenland, fixes #21254.

Note: See TracTickets for help on using tickets.