WordPress.org

Make WordPress Core

#21255 closed defect (bug) (fixed)

Twenty Twelve: Tag and category descriptions should not be part of H1 tag

Reported by: obenland Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: ui-feedback
Focuses: Cc:

Description

Ticket based on Lance's comment.

If we do change that, we would also have to come up with a design decision on how to display the description.

Attachments (5)

21255.diff (1.9 KB) - added by obenland 22 months ago.
Addresses the archive.php part of the change. Style still missing.
21255.2.diff (4.1 KB) - added by obenland 22 months ago.
Proposed handling of archive descriptions
archive-descriptions-21255.png (65.8 KB) - added by obenland 22 months ago.
Result of 21255.2.diff
21255.3.diff (579 bytes) - added by drewstrojny 21 months ago.
archive-descriptions-21255.3.png (28.2 KB) - added by drewstrojny 21 months ago.

Download all attachments as: .zip

Change History (12)

obenland22 months ago

Addresses the archive.php part of the change. Style still missing.

comment:1 ocean9022 months ago

  • Milestone changed from Awaiting Review to 3.5

obenland22 months ago

Proposed handling of archive descriptions

obenland22 months ago

Result of 21255.2.diff

comment:2 follow-up: obenland22 months ago

21255.2.diff proposes a <header> tag like in search.php, wrapping title and desc, to have only one baseline no matter whether there is a description or not.

Descriptions styling is essentially like .archive-title sans boldness.

See archive-descriptions-21255.png for result.

comment:3 in reply to: ↑ 2 lancewillett21 months ago

Chatted with Drew on this today, we agreed it's not intentional to have the div elements nested inside the h1 elements.

@obenland Thanks for the patch, I'll take a look soon and get this in.

comment:4 lancewillett21 months ago

In [21331]:

Twenty Twelve: tag and category descriptions should not be part of h1 element. Props obenland, see #21255.

comment:5 lancewillett21 months ago

  • Keywords ui-feedback added; needs-ui has-patch removed

Leaving open for @drewstrojny to look at the design / CSS for the output for tag and category descriptions.

drewstrojny21 months ago

comment:6 drewstrojny21 months ago

This is good to go on my end. See 21255.3.diff and associated screenshot.

comment:7 lancewillett21 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21397]:

Twenty Twelve: update styles for tag/category descriptions on archive pages, props drewstrojny. Closes #21255.

Note: See TracTickets for help on using tickets.