WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21262 closed enhancement (fixed)

Twenty Twelve: I think the <address> tag needs a little more line-height

Reported by: sennza's profile sennza Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

It's only a little tweak but I think it makes a difference!

Attachments (4)

address-before.jpg​ (24.9 KB) - added by sennza 12 years ago.
address-after.jpg​ (25.5 KB) - added by sennza 12 years ago.
21262.patch​ (526 bytes) - added by sennza 12 years ago.
21262.1.patch​ (417 bytes) - added by drewstrojny 12 years ago.

Download all attachments as: .zip

Change History (9)

@sennza
12 years ago

@sennza
12 years ago

@sennza
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @obenland
12 years ago

  • Cc konstantin@… added

@drewstrojny
12 years ago

#3 @drewstrojny
12 years ago

Good catch sennza. I tweaked your styling a bit to use the default line height in the updated patch. Keep in mind for future patches, we're using unitless line-height values:

​http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/

#4 @lancewillett
12 years ago

  • Cc lancewillett added

#5 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21338]:

Twenty Twelve: give address element a little more line-height, props sennza and drewstrojny. Fixes #21262.

Note: See TracTickets for help on using tickets.