Kill the serialization of $wp_filter in get_terms()
|Reported by:||nacin||Owned by:|
|Component:||Cache API||Keywords:||has-patch 3.9-early|
Description (last modified by scribu)
We use this as part of a persistent cache key:
This is not good for two reasons. First, well, it's a not fun to reach into our internal API like that. But worse, it's broken whenever an object method is used, because spl_object_hash() will be unique to that object, thus rendering the cache invalidated on the next pageload.
As an aside, we should probably have _wp_filter_build_unique_id() create a delimiter when dealing with a static class method — $function.$function can conflict with a legitimate function name.
I'm not sure how this should be fixed.
Change History (19)
comment:6 @wonderboymusic — 3 years ago
- Keywords has-patch added; needs-patch removed
comment:13 @wonderboymusic — 2 years ago
- Keywords needs-unit-tests needs-testing added
- Milestone changed from Future Release to 3.7
comment:14 @wonderboymusic — 2 years ago
- Keywords needs-unit-tests needs-testing removed
- Milestone changed from 3.7 to 3.8
- Keywords 3.9-early added
- Milestone changed from 3.8 to Future Release