reporting typo in dbDelta

[apimlott]

In dbDelta, there is the section:

                // For every remaining index specified for the table
                foreach ( (array) $indices as $index ) {
                        // Push a query line into $cqueries that adds the index to that table
                        $cqueries[] = "ALTER TABLE {$table} ADD $index";
                        $for_update[$table.'.'.$fieldname] = 'Added index '.$table.' '.$index;
                }

Note that $for_update is updated with the wrong array index. This causes some updates not to be returned in $for_update. Better would be:

                        $for_update[$table.'.'.$index] = 'Added index '.$table.' '.$index;

Even this is not really right, since indexes and columns may have the same names. Given that the users of dbDelta don't even seem to care about the keys, it might be simpler just to change all the $for_update lines to

                        $for_update[] = ...

except for the first one that must be keyed on table name.

[wonderboymusic]

Now arbitrarily adds items to array, rather than clobbering the key in the loop. Patch added.

[wonderboymusic]

Updated patch applies cleanly against trunk

[nacin]

In 24584:

Avoid possible array collision in dbDelta when recording index adds. props apimlott, wonderboymusic. fixes #21272.