Respect 'suppress_filters' arg in WP_Query->get_posts()

[brandondove]

Before trying to run filters, there's a check to see if we should suppress filters using the suppress_filters arg. Four filters run whether or not suppress_filters is set to true. This patch just adds checks against that arg for those filter calls.

[brandondove]

After scanning through core, 'the_preview' filter is used when previewing a post. I've removed the suppress filters check for that filter.

[scribu]

After scanning through core, 'the_preview' filter is used when previewing a post. I've removed the suppress filters check for that filter.

That doesn't sound like a good reason; if Core needs 'the_preview' filter, it shouldn't pass 'suppress_filters' => true, no?

[brandondove]

Replying to scribu:

That doesn't sound like a good reason; if Core needs 'the_preview' filter, it shouldn't pass 'suppress_filters' => true, no?

That's why I took that suppress filters check out on that filter. If core needs it, we can't suppress it.

[nacin]

From ryan: "Some things in there like split query should run regardless of suppress."

It isn't a huge problem if we don't respect suppress for filters introduced after get_posts() was rewritten to wrap WP_Query in 2.7, as we at least did not change behavior.

Punting for further study.

[wonderboymusic]

Is this still considered an issue?

[brandondove]

The issue still exists in core, but per Nacin's feedback, it seems like this isn't something that needs to be solved.