WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#21281 closed defect (bug) (fixed)

RTL indention icons need to be flipped

Reported by: almogbaku's profile AlmogBaku Owned by: azaozz's profile azaozz
Milestone: 4.2 Priority: normal
Severity: major Version: 3.4
Component: TinyMCE Keywords: has-patch
Focuses: rtl Cc:

Description

By clicking the padding button(for indention) the action not works - it warpped the text by "p" element with padding-left insted or padding-right in RTL.

Attachments (2)

21281.patch​ (475 bytes) - added by iseulde 10 years ago.
21281.2.patch​ (462 bytes) - added by iseulde 10 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
13 years ago

  • Component changed from Editor to TinyMCE

Seems to be broken since 2.5 (2.3.3 used nested <blockquote> tags for indentation).

I've tried to add directionality : "rtl" and directionality plugin to ​TinyMCE fiddle config, and couldn't make indentation work there either.

#2 @nacin
13 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

#3 @azaozz
12 years ago

  • Cc spocke added

#4 @azaozz
12 years ago

Seems this should be fixed upstream.

#5 @SergeyBiryukov
12 years ago

#23360 was marked as a duplicate.

#6 @iseulde
10 years ago

  • Focuses rtl added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 3.4.1 to 3.4

It looks like the icons just need to be flipped here.

@iseulde
10 years ago

#7 @iseulde
10 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.2

Also a few more questions...

  • Do we need to flip the undo/redo icons for rtl?
  • Maybe these also need to be flipped in dashicons.css. Maybe also worth looking for other icons that might need to be flipped.

#8 @iseulde
10 years ago

  • Summary changed from RTL wysiwyg "padding"/"indention" action is not works as expected. to RTL indention icons need to be flipped

@iseulde
10 years ago

#9 @iseulde
10 years ago

Reference: @azaozz asked about the undo/redo in #polyglots:
​https://wordpress.slack.com/archives/polyglots/p1421001395000007

#10 follow-up: @azaozz
10 years ago

21281.2.patch looks good. Thinking it's better to open new ticket if we are going to switch the icons for undo/redo, and perhaps another one for any dashicons that need to be flipped for RTL.

#11 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [31142]:

TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281.

#12 in reply to: ↑ 10 @SergeyBiryukov
10 years ago

Replying to azaozz:

Thinking it's better to open new ticket if we are going to switch the icons for undo/redo

Follow-up: #31798

Note: See TracTickets for help on using tickets.