Make WordPress Core

Opened 14 years ago

Closed 12 years ago

Last modified 11 years ago

#21281 closed defect (bug) (fixed)

RTL indention icons need to be flipped

Reported by: AlmogBaku Owned by: azaozz
Priority: normal Milestone: 4.2
Component: TinyMCE Version: 3.4
Severity: major Keywords: has-patch
Cc: Focuses: rtl

Description

By clicking the padding button(for indention) the action not works - it warpped the text by "p" element with padding-left insted or padding-right in RTL.

Attachments (2)

21281.patch (475 bytes ) - added by iseulde 12 years ago.
21281.2.patch (462 bytes ) - added by iseulde 12 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
14 years ago

  • Component EditorTinyMCE

Seems to be broken since 2.5 (2.3.3 used nested <blockquote> tags for indentation).

I've tried to add directionality : "rtl" and directionality plugin to TinyMCE fiddle config, and couldn't make indentation work there either.

#2 @nacin
14 years ago

  • Owner set to azaozz
  • Status newassigned

#3 @azaozz
14 years ago

  • Cc spocke added

#4 @azaozz
14 years ago

Seems this should be fixed upstream.

#5 @SergeyBiryukov
14 years ago

#23360 was marked as a duplicate.

#6 @iseulde
12 years ago

  • Focuses rtl added
  • Keywords needs-patch added
  • Milestone Awaiting ReviewFuture Release
  • Version 3.4.13.4

It looks like the icons just need to be flipped here.

@iseulde
12 years ago

#7 @iseulde
12 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone Future Release4.2

Also a few more questions...

  • Do we need to flip the undo/redo icons for rtl?
  • Maybe these also need to be flipped in dashicons.css. Maybe also worth looking for other icons that might need to be flipped.

#8 @iseulde
12 years ago

  • Summary RTL wysiwyg "padding"/"indention" action is not works as expected.RTL indention icons need to be flipped

@iseulde
12 years ago

#9 @iseulde
12 years ago

Reference: @azaozz asked about the undo/redo in #polyglots:
https://wordpress.slack.com/archives/polyglots/p1421001395000007

#10 follow-up: @azaozz
12 years ago

21281.2.patch looks good. Thinking it's better to open new ticket if we are going to switch the icons for undo/redo, and perhaps another one for any dashicons that need to be flipped for RTL.

#11 @azaozz
12 years ago

  • Resolutionfixed
  • Status assignedclosed

In [31142]:

TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281.

#12 in reply to: ↑ 10 @SergeyBiryukov
11 years ago

Replying to azaozz:

Thinking it's better to open new ticket if we are going to switch the icons for undo/redo

Follow-up: #31798

Note: See TracTickets for help on using tickets.