WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 7 weeks ago

#21281 closed defect (bug) (fixed)

RTL indention icons need to be flipped

Reported by: AlmogBaku Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: major Version: 3.4
Component: TinyMCE Keywords: has-patch
Focuses: rtl Cc:

Description

By clicking the padding button(for indention) the action not works - it warpped the text by "p" element with padding-left insted or padding-right in RTL.

Attachments (2)

21281.patch (475 bytes) - added by iseulde 7 weeks ago.
21281.2.patch (462 bytes) - added by iseulde 7 weeks ago.

Download all attachments as: .zip

Change History (13)

comment:1 @SergeyBiryukov3 years ago

  • Component changed from Editor to TinyMCE

Seems to be broken since 2.5 (2.3.3 used nested <blockquote> tags for indentation).

I've tried to add directionality : "rtl" and directionality plugin to TinyMCE fiddle config, and couldn't make indentation work there either.

comment:2 @nacin3 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

comment:3 @azaozz2 years ago

  • Cc spocke added

comment:4 @azaozz2 years ago

Seems this should be fixed upstream.

comment:5 @SergeyBiryukov2 years ago

#23360 was marked as a duplicate.

comment:6 @iseulde7 weeks ago

  • Focuses rtl added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 3.4.1 to 3.4

It looks like the icons just need to be flipped here.

@iseulde7 weeks ago

comment:7 @iseulde7 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.2

Also a few more questions...

  • Do we need to flip the undo/redo icons for rtl?
  • Maybe these also need to be flipped in dashicons.css. Maybe also worth looking for other icons that might need to be flipped.

comment:8 @iseulde7 weeks ago

  • Summary changed from RTL wysiwyg "padding"/"indention" action is not works as expected. to RTL indention icons need to be flipped

@iseulde7 weeks ago

comment:9 @iseulde7 weeks ago

Reference: @azaozz asked about the undo/redo in #polyglots:
https://wordpress.slack.com/archives/polyglots/p1421001395000007

comment:10 @azaozz7 weeks ago

21281.2.patch looks good. Thinking it's better to open new ticket if we are going to switch the icons for undo/redo, and perhaps another one for any dashicons that need to be flipped for RTL.

comment:11 @azaozz7 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [31142]:

TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281.

Note: See TracTickets for help on using tickets.