WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#21285 closed defect (bug) (wontfix)

Don't ping yourself, especially on localhost

Reported by: wonderboymusic Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.2
Component: Pings/Trackbacks Keywords:
Focuses: Cc:
PR Number:

Description

This may just be a conversation starter, but I know these things to be true:

1) there is duplicated code spread between pingback( ) and do_enclose( )
2) If your post contains a bunch of links to your own site, and you save your post in the admin, you will ended up with memory leaks all over the place / seg faults / etc when you get hammered by HEAD requests triggered by the immediate cron that is spawned by the post being saved
3) you probably don't need to trackback yourself anyways

I moved some dupe code into functions and added some checks so we don't ping ourself when saving

Attachments (1)

pings.diff (5.2 KB) - added by wonderboymusic 7 years ago.

Download all attachments as: .zip

Change History (6)

@wonderboymusic
7 years ago

#1 @dd32
7 years ago

for self-pings see #5224 and #14811

#3 @chriscct7
4 years ago

  • Keywords needs-refresh added

#4 @dshanske
4 years ago

  • Keywords close added; needs-refresh has-patch removed
  • Resolution set to wontfix
  • Status changed from new to closed

I think it was agreed with the initial post of tickets that self-pinging is something that should not be disabled, and there were plugins to address this outside of Core.

The second and third issue are already addressed. The existing code has the parsing code separated out and you won't trackback if you ping.

So the purpose for the ticket has essentially expired by now.

#5 @DrewAPicture
4 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.