WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 15 months ago

#21285 new defect (bug)

Don't ping yourself, especially on localhost

Reported by: wonderboymusic Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 1.2
Component: Pings/Trackbacks Keywords: has-patch
Focuses: Cc:

Description

This may just be a conversation starter, but I know these things to be true:

1) there is duplicated code spread between pingback( ) and do_enclose( )
2) If your post contains a bunch of links to your own site, and you save your post in the admin, you will ended up with memory leaks all over the place / seg faults / etc when you get hammered by HEAD requests triggered by the immediate cron that is spawned by the post being saved
3) you probably don't need to trackback yourself anyways

I moved some dupe code into functions and added some checks so we don't ping ourself when saving

Attachments (1)

pings.diff (5.2 KB) - added by wonderboymusic 21 months ago.

Download all attachments as: .zip

Change History (3)

wonderboymusic21 months ago

comment:1 dd3221 months ago

for self-pings see #5224 and #14811

Note: See TracTickets for help on using tickets.