WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#21297 closed enhancement (fixed)

Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

Reported by: Mamaduka Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

As WordPress requires PHP5 I think it's better if we use same version constructor.

Attachments (3)

21297.diff​ (548 bytes ) - added by Mamaduka 14 years ago.
21297.2.diff​ (2.8 KB ) - added by obenland 14 years ago.
Adds visibility keywords
21297.3.diff​ (4.0 KB ) - added by obenland 14 years ago.
Added documentation

Download all attachments as: .zip

Change History (8)

@Mamaduka
14 years ago

#1 @Mamaduka
14 years ago

  • Keywords has-patch added

#2 @nacin
14 years ago

  • Milestone Awaiting Review → 3.5

Same goes for visibility.

@obenland
14 years ago

Adds visibility keywords

@obenland
14 years ago

Added documentation

#3 @ocean90
14 years ago

  • Component General → Bundled Theme

#4 @lancewillett
14 years ago

  • Summary Twenty Twelve: Use PHP5 constructor in theme options class → Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

This is great, thanks for the ticket and patch. Agreed on going with the correct PHP5 notation.

#5 @lancewillett
14 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In [21280]:

Twenty Twelve: update theme options file to use PHP5 constructor and visibility keywords, and also minor DocBlock cleanup. Props Mamaduka and obenland, closes #21297.

Note: See TracTickets for help on using tickets.