WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21297 closed enhancement (fixed)

Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

Reported by: mamaduka's profile Mamaduka Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

As WordPress requires PHP5 I think it's better if we use same version constructor.

Attachments (3)

21297.diff​ (548 bytes) - added by Mamaduka 12 years ago.
21297.2.diff​ (2.8 KB) - added by obenland 12 years ago.
Adds visibility keywords
21297.3.diff​ (4.0 KB) - added by obenland 12 years ago.
Added documentation

Download all attachments as: .zip

Change History (8)

@Mamaduka
12 years ago

#1 @Mamaduka
12 years ago

  • Keywords has-patch added

#2 @nacin
12 years ago

  • Milestone changed from Awaiting Review to 3.5

Same goes for visibility.

@obenland
12 years ago

Adds visibility keywords

@obenland
12 years ago

Added documentation

#3 @ocean90
12 years ago

  • Component changed from General to Bundled Theme

#4 @lancewillett
12 years ago

  • Summary changed from Twenty Twelve: Use PHP5 constructor in theme options class to Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

This is great, thanks for the ticket and patch. Agreed on going with the correct PHP5 notation.

#5 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21280]:

Twenty Twelve: update theme options file to use PHP5 constructor and visibility keywords, and also minor DocBlock cleanup. Props Mamaduka and obenland, closes #21297.

Note: See TracTickets for help on using tickets.