WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 4 years ago

#21304 closed enhancement (wontfix)

Create unique file for rotated images

Reported by: wpdavis Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

When images are cropped in WordPress, the resulting file is given a unique filename, which helps in two ways — the original is preserved, and it also busts any caching. Preserving the original isn't such a major concern when we're talking about rotating the image, but caching still can be an issue. I propose that when images are rotated they're given a unique filename to bust through any caching or CDN that the image has already gone to.

Change History (2)

#1 @mikeschroder
6 years ago

Hi wpdavis! Apologies that this ticket went so long without a reply.

I'm mixed on this. I do see the value in maintaining a gold-master for images.

However, in this case, unless the image is square, in half of the cases (presuming that an image is usually rotated once for initial posting), we'd be creating a new filename anyway, since the dimensions generally change when rotating 90 degrees in either direction.

This, along with the the relative rarity of having a CDN (that you're not handling automatic flushing via the admin) or persistent image caching makes the edge case you're talking about seem relatively small, but would affect a number of hosting companies and users that have issues with total file counts.

Are there hooks that are missing in core to prevent clearing the image caches you're looking to bust?

I'm not thoroughly against the idea, but would be interested to hear use-cases where this affects a large enough group of users to warrant the increase in file numbers.

Related: #21810

#2 @chriscct7
4 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix. Complete lack of interest on the feature on the ticket over the last 2 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)

Note: See TracTickets for help on using tickets.