RTE align buttons use deprecated HTML attributes

[seth]

When using the align buttons, they generate markup like:

<p align="center"></p>

It would be much better to have them use the style attribute:

<p style="text-align: center"></p>

[darkfate]

Is this still valid for 2.0.3?

[foolswisdom]

ENV: WP 2.1-alpha3 (r4198)

Yes, darkfate, using RTE, this still seems as described.

seth, what do you mean by "invalid markup"?

[kccricket]

It would be better to say that they use deprecated HTML attributes.

See:
​http://www.w3.org/TR/html4/present/graphics.html#adef-align

[foolswisdom]

Relates to #3618

[JeremyVisser]

No, it's invalid markup in XHTML 1.0 Strict (and XHTML 1.1, etc.). Most themes use XHTML 1.0 Transitional and the align attribute is only deprecated in Transitional.

[foolswisdom]

#1607 , #3618 closed as dup of this ticket.

[johnbillion]

Note that the left/center/right align buttons have a different effect when used on images instead of paragraphs.

The align="left" attribute works like style="float:left" instead of style="text-align:left" and the same goes for the right-align button (with float:right obviously). This will need to be taken into consideration if this issue is to be fixed.

[johnbillion]

What I mean to say is, when the left/right button is used on an image, the HTML which is inserted will need to be different (style="float:left" instead of style="text-align:left").

[Nazgul]

Reported upstream: ​text-align bug and ​image float bug

[thee17]

Still not addressed by TinyMCE tickets submitted by Nazgul should be pushed.

[thee17]

brought back incase gets addressed before march

[Nazgul]

Maybe fixed by #5674. Needs testing when that ticket matures.

[thee17]

Works! TinyMCE 3.0 fixed it.