WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #21324, comment 46


Ignore:
Timestamp:
10/18/12 14:02:22 (18 months ago)
Author:
lessbloat
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21324, comment 46

    v1 v2  
    44- With that said... The background color can only work if the links blur on click. What happens otherwise in some browsers (FF specifically) when you click a link, for a brief second (before the page redirects), the link is focused, and the background color shows. This is jarring, and regrettably not acceptable in my mind. If we must do away with auto-bluring on click, we've got to get rid of having a background color for links on :focus. 
    55- Personally, I'd prefer that we avoid having to add a "high visibility" setting, if at all possible. The reason I was happy with the solution in 21324.11.diff was because it seemed like a win-win.  A happy medium. 
    6 - In 21324.12.diff I've taken us back to using outlines instead of a background color, and I've removed the auto-blur JS.  I'd love to get this reviewed quickly, and get it committed so that those with more accessibility experience can review it without having to apply a patch. 
     6- In 21324.12.diff I've moved us to using outlines instead of a background color, and I've removed the auto-blur JS.  I'd love to get this reviewed quickly, and get it committed so that those with more accessibility experience can review it without having to apply a patch. 
    77- I also noticed that along the way we've lost almost all :focus styles on the new buttons.  I'll address this over on #21598