Consolidate filters and functions in wp-admin/includes/media.php

[martythornley]

in wp-admin/media.php, there are several functions that do similar things and could be combined, simplifying how they get used.

[scribu]

It would be good if you added a useful description to this new media_upload() function.

Also, I'm not sure about the implications of changing the filter from:

"media_upload_$type"

to:

"media_upload", $type

[scribu]

You could use current_filter() to gleam the type in the callback.

[martythornley]

I wasn't aware of the current_filter() function. Here is take 2 with the original filters back in place.

[martythornley]

related #14829

[martythornley]

Added some function descriptions to help clarify

[martythornley]

I'm just going to keep going with this ticket in an attempt to cleanup the media.php file and all its functions. Maybe some of it will be useful or some will be a waste of time but I have some time to kill. :)

[martythornley]

remove media_upload_gallery and media_upload_library, add comments about functions that could be deprecated to end of file

[martythornley]

Ignore patch 3 and 4. I was grabbing wrong patch files. Sorry. Would remove them if I could see how.

[martythornley]

Fixed version of previous patches

[martythornley]

More reorganization and intro wp_upload_form()

[martythornley]

I have the patches between 5 and 8 if you want to see my steps but this was all just a reorganization of existing functions, making sure upload thickbox still worked for all tabs.

In 8, I grouped all the html for a standalone upload form ( the dragndrop area ) into one function wp_upload_form() that takes a number af $args to define it. I haven't tested replacing the inline form in media-new.php but it works as a replacement in the post/page upload window.

[scribu]

Is this still relevant?

[nacin]

If this reduced the amount of code in the file, making it easier to maintain as we slowly wind down support for the legacy media code, I think I'd be for it. But it actually adds a few dozen lines.

[c3mdigital]

Seems like a lot of code changes to be making on a legacy component. Mostly refactoring see: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/