Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#21351 closed defect (bug) (fixed)

type=search breaks internal linking spinner position

Reported by: nacin Owned by: azaozz
Milestone: 3.4.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

Some editor.css styling is applied to type=text, which breaks when we moved to type=search.

Attachments (3)

21351.png (11.9 KB) - added by nacin 10 years ago.
21351.patch (1.9 KB) - added by azaozz 10 years ago.
spinner.png (2.4 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (12)

@nacin
10 years ago

@azaozz
10 years ago

@azaozz
10 years ago

#1 @azaozz
10 years ago

The spinner appears between the label and the search field there, making the search field jump right. 21351.patch moves the spinner on the left of the label (no jumping) and fixes the vertical alignment.


Last edited 10 years ago by azaozz (previous) (diff)

#2 @azaozz
10 years ago

Don't see any differences in styling input[type="text"] and input[type="search"], all seem fixed.

#3 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [21306]:

Fix internal linking search spinner position, fixes #21351

Last edited 10 years ago by azaozz (previous) (diff)

#4 @azaozz
10 years ago

In [21307]:

Fix internal linking search spinner position by reverting the search field's type to "text", fixes #21351 for 3.4

#5 @toscho
10 years ago

  • Cc info@… added

Shouldn’t the spinner sit on the right side of the search field?

In the order of actual actions this would feel more … natural:

Search … for keywordswait

results

#6 @nacin
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

That's where it was in 3.3.

#7 @azaozz
10 years ago

All other similar places have the spinner to the left, but yes, it was to the right in the internal linking popup in 3.3. Will move it back.

#8 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21319]:

Put the spinner back to the right of the search field in internal linking, fixes #21351

#9 @azaozz
10 years ago

In [21320]:

RTL css for the spinner in internal linking, see #21351

Note: See TracTickets for help on using tickets.