WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21351 closed defect (bug) (fixed)

type=search breaks internal linking spinner position

Reported by: nacin Owned by: azaozz
Milestone: 3.4.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

Some editor.css styling is applied to type=text, which breaks when we moved to type=search.

Attachments (3)

21351.png (11.9 KB) - added by nacin 3 years ago.
21351.patch (1.9 KB) - added by azaozz 3 years ago.
spinner.png (2.4 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (12)

@nacin3 years ago

@azaozz3 years ago

@azaozz3 years ago

comment:1 @azaozz3 years ago

The spinner appears between the label and the search field there, making the search field jump right. 21351.patch moves the spinner on the left of the label (no jumping) and fixes the vertical alignment.


Last edited 3 years ago by azaozz (previous) (diff)

comment:2 @azaozz3 years ago

Don't see any differences in styling input[type="text"] and input[type="search"], all seem fixed.

comment:3 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [21306]:

Fix internal linking search spinner position, fixes #21351

Version 0, edited 3 years ago by azaozz (next)

comment:4 @azaozz3 years ago

In [21307]:

Fix internal linking search spinner position by reverting the search field's type to "text", fixes #21351 for 3.4

comment:5 @toscho3 years ago

  • Cc info@… added

Shouldn’t the spinner sit on the right side of the search field?

In the order of actual actions this would feel more … natural:

Search … for keywordswait

results

comment:6 @nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

That's where it was in 3.3.

comment:7 @azaozz3 years ago

All other similar places have the spinner to the left, but yes, it was to the right in the internal linking popup in 3.3. Will move it back.

comment:8 @azaozz3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21319]:

Put the spinner back to the right of the search field in internal linking, fixes #21351

comment:9 @azaozz3 years ago

In [21320]:

RTL css for the spinner in internal linking, see #21351

Note: See TracTickets for help on using tickets.