Twenty Twelve: add editor stylesheet

[lancewillett]

Add editor-style.css to style up the Visual Editor with basic typography and look-and-feel from Twenty Twelve's main stylesheet.

[obenland]

Iteration 1

[obenland]

So I added a first patch for the editor style.

Three things:

• We need to think about how we add the optional font. I approached it by adding two editor stylesheets. One with the font, that gets added optionally and one with the actual editor style. I don't know, can we alter class names inside the editor? Or add a class conditionally?

• I ran across a few tags that don't have styles yet in the main stylesheet: hr, big, del, ins

• The comment submit button is not styled. Is that intentional or should we open another ticket for that?

I'd appreciate it if you guys could give the patch a spin and give me feedback! I'll keep testing it with the Theme Unit Test in the meantime.

Thanks,
Konstantin

[obenland]

Iteration 2

[obenland]

The second iteration completes all existing tags. Tested heavily with Layout Test and Image Test.

Still missing:

• Styles for hr, big, del, ins
• Explanation for the second add_editor_style() call

[DrewAPicture]

I realize Core's ​CSS Coding Standards are still a work in progress, but I think we can at the very least cherry-pick a couple of them to apply in this situation, namely group and selector spacing, as well as making sure selector groups are always multi-line.

Incremental patch attached.

[DrewAPicture]

group and selector spacing, etc.

[obenland]

Related: #21399

[lancewillett]

Noting we'll need the equivalent RTL version as well.

[lancewillett]

In [21389]:

Twenty Twelve: add editor stylesheet, first pass props obenland. See #21376.

RTL version and tweaks to come after more testing.

[obenland]

Iteration 3

[obenland]

21376.4.diff​ adds RTL support, merges .alignleft margins and respects CSS guidelines (props @DrewAPicture)

[lancewillett]

In [21406]:

Twenty Twelve: style hr, big, del, ins in editor stylesheet (and add all except big to style.css also). Fixes #21376.

[obenland]

Will editor-style.rtl.css run through #21441?

[lancewillett]

Replying to obenland:

respects CSS guidelines (props @DrewAPicture)

DrewAPicture and obenland, let's stick with our current standard of no lines between style declaration blocks. It's what we've done with previous default themes.

[lancewillett]

Replying to obenland:

Will editor-style.rtl.css run through #21441?

Yes please.

[obenland]

I'm not sure whether 21376.6.diff​ is still needed, it's just minor.

Anyway, updated the original patch sans editor-style-rtl.css file.

[lancewillett]

Replying to obenland:

I'm not sure whether 21376.6.diff​ is still needed, it's just minor.

Anyway, updated the original patch sans editor-style-rtl.css file.

Thanks, we do need the rest of the cleanup (selectors only one per line, etc).

[lancewillett]

In [21409]:

Twenty Twelve: update editor stylesheet, props obenland. See #21376.

[lancewillett]

Editor styles for v 1.0 are good to go, new issues should be opened in new tickets.

[lancewillett]

In [21566]:

Twenty Twelve: add in missing style.css tag for 'editor-style', see #21376.