![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#21376 closed enhancement (fixed)
Twenty Twelve: add editor stylesheet
| Reported by: | lancewillett | Owned by: | lancewillett |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | ui-feedback has-patch |
| Cc: | Focuses: |
Description
Add editor-style.css to style up the Visual Editor with basic typography and look-and-feel from Twenty Twelve's main stylesheet.
Attachments (6)
Change History (23)
#2
@
14 years ago
- Keywords has-patch added; needs-patch removed
So I added a first patch for the editor style.
Three things:
- We need to think about how we add the optional font. I approached it by adding two editor stylesheets. One with the font, that gets added optionally and one with the actual editor style. I don't know, can we alter class names inside the editor? Or add a class conditionally?
- I ran across a few tags that don't have styles yet in the main stylesheet: hr, big, del, ins
- The comment submit button is not styled. Is that intentional or should we open another ticket for that?
I'd appreciate it if you guys could give the patch a spin and give me feedback! I'll keep testing it with the Theme Unit Test in the meantime.
Thanks,
Konstantin
#3
@
14 years ago
The second iteration completes all existing tags. Tested heavily with Layout Test and Image Test.
Still missing:
- Styles for hr, big, del, ins
- Explanation for the second
add_editor_style()call
#4
@
14 years ago
I realize Core's CSS Coding Standards are still a work in progress, but I think we can at the very least cherry-pick a couple of them to apply in this situation, namely group and selector spacing, as well as making sure selector groups are always multi-line.
Incremental patch attached.
#8
follow-up:
↓ 11
@
14 years ago
21376.4.diff adds RTL support, merges .alignleft margins and respects CSS guidelines (props @DrewAPicture)
#11
in reply to: ↑ 8
@
14 years ago
- Resolution fixed
- Status closed → reopened
Replying to obenland:
respects CSS guidelines (props @DrewAPicture)
DrewAPicture and obenland, let's stick with our current standard of no lines between style declaration blocks. It's what we've done with previous default themes.
#13
follow-up:
↓ 14
@
14 years ago
I'm not sure whether 21376.6.diff is still needed, it's just minor.
Anyway, updated the original patch sans editor-style-rtl.css file.
#14
in reply to: ↑ 13
@
14 years ago
Replying to obenland:
I'm not sure whether 21376.6.diff is still needed, it's just minor.
Anyway, updated the original patch sans
editor-style-rtl.cssfile.
Thanks, we do need the rest of the cleanup (selectors only one per line, etc).
Iteration 1