WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21377 closed enhancement (fixed)

Twenty Twelve: add print styles to stylesheet

Reported by: lancewillett Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: ui-feedback has-patch
Focuses: Cc:

Description

Add a media block to main stylesheet to format print output nicely, Twenty Eleven has a great example to use as a starting point.

Goal is to keep it simple and readable.

Attachments (2)

21377.diff (2.6 KB) - added by obenland 3 years ago.
Iteration 1
21377.2.diff (1.9 KB) - added by SergeyBiryukov 3 years ago.
Combine similar styles

Download all attachments as: .zip

Change History (9)

@obenland3 years ago

Iteration 1

comment:1 @obenland3 years ago

  • Keywords has-patch added; needs-patch removed

21377.diff adds print styles. Probably needs to be revisited after #21379 No. 2 was addressed.

comment:2 @lancewillett3 years ago

Iteration 1 looks good, just a few tiny syntax errors like text-align: left: (should be semi-colon) and adding in the =Print comment header to the new block.

comment:3 @lancewillett3 years ago

In [21392]:

Twenty Twelve: add print styles to stylesheet, first pass props obenland. See #21377.

@SergeyBiryukov3 years ago

Combine similar styles

comment:4 @lancewillett3 years ago

In [21410]:

Twenty Twelve: update print styles to merge similar rules, props SergeyBiryukov, see #21377.

comment:5 @lancewillett3 years ago

Reviewing with drewstrojny:

  • Make entry meta text color a bit darker
  • Remove underline text-decoration under links

comment:6 @lancewillett3 years ago

In [21427]:

Twenty Twelve: print style tweaks for footer meta and link underlines. See #21377.

comment:7 @lancewillett3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Print stylesheets are good for v 1.0. We can fix bugs in new tickets.

Note: See TracTickets for help on using tickets.