WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#21400 closed defect (bug) (fixed)

comment_ID is misspelled in wp_set_wpdb_vars()

Reported by: wonderboymusic Owned by: ryan
Priority: normal Milestone: 3.5
Component: Database Version: 3.0
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

I was doing some serious debugging of query formatting and noticed comment_ID always being formatted as %s.

Guess why? It's spelled with three (3) Ms = commment_ID in wp_set_wpdb_vars( ), meaning every insert or update without formatting explicitly passed is skipping $wpdb->field_types

Attachments (1)

comment-spelling.diff​ (997 bytes ) - added by wonderboymusic 14 years ago.

Download all attachments as: .zip

Change History (4)

@wonderboymusic
14 years ago

#1 @wonderboymusic
14 years ago

This is also fixed here: #19019

Last edited 14 years ago by SergeyBiryukov (previous) (diff)

#2 @SergeyBiryukov
14 years ago

  • Milestone Awaiting Review → 3.5

#3 @ryan
14 years ago

  • Owner set to ryan
  • Resolution → fixed
  • Status new → closed

In [21363]:

Take the mmm out of comment_ID. Just mm is sufficient.

Props wonderboymusic
fixes #21400

Note: See TracTickets for help on using tickets.