WordPress.org

Make WordPress Core

#21404 closed enhancement (wontfix)

Twenty Twelve: "Only" use Customizer for Theme Settings

Reported by: obenland Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Currently we have an entire Theme Settings page for one checkbox in Twenty Twelve.

After reading Otto's second post on the Theme Customizer I'd be very intrigued to not offer a settings page but only use the Customizer to - well - customize the Theme. For the purpose of providing an implementation best practice for Theme Options we'd still have Twenty Eleven. Though after reading the article, I consider considering the Customizer as best practice. :)

What do you say?

Attachments (3)

21404.diff (10.4 KB) - added by obenland 21 months ago.
Possible implementation
21404.2.diff (10.4 KB) - added by obenland 21 months ago.
Web font default true
21404.3.diff (7.1 KB) - added by obenland 21 months ago.
Keeps Theme Options page for versions prior to 3.4

Download all attachments as: .zip

Change History (14)

comment:1 helenyhou21 months ago

Customizer would need to be made accessible first: #21283

comment:2 scribu21 months ago

  • Cc scribu added

obenland21 months ago

Possible implementation

comment:3 follow-up: obenland21 months ago

Option would not be available for WordPress versions prior to 3.4.

comment:4 in reply to: ↑ 3 ; follow-up: DrewAPicture21 months ago

  • Cc xoodrew@… added

Replying to obenland:

Option would not be available for WordPress versions prior to 3.4.

That's a good point. I still think this would be a great way to pimp using the Customizer for theme options. Can we do a back-compat fallback that adds the theme options page for pre-3.4?

comment:5 in reply to: ↑ 4 obenland21 months ago

Replying to DrewAPicture:

Can we do a back-compat fallback that adds the theme options page for pre-3.4?

If we'd keep using options instead of theme_mod all the way (for forward compatibility), I think we could.

Just for my info: Is not using a class for the Theme Options ... an option?

comment:6 sabreuse21 months ago

  • Cc sabreuse@… added

comment:8 follow-up: Mamaduka21 months ago

Nice idea, but as I remember from this week's dev chat Twenty Twelve compatibility is to 3.1, so I think we should leave back-comp for theme options.

I like implementing Theme Options as a class, it make code cleaner and prefixing all the things easier.

obenland21 months ago

Web font default true

comment:9 obenland21 months ago

It would be 3.1 compatible as in: not break.

There's a lot of possibilities:

  • Not have the web font option available until 3.4 with Open Sans disabled until Customizer available. (21404.diff)
  • Not have the web font option available until 3.4 with Open Sans enabled by default until Customizer available. This would keep the example of using a web font available for all versions. (21404.2.diff)
  • Have pre 3.4 Theme Option only, then Customizer only. Might lead to some duplicate code, though.
  • Leave as is.

obenland21 months ago

Keeps Theme Options page for versions prior to 3.4

comment:10 in reply to: ↑ 8 lancewillett21 months ago

Replying to Mamaduka:

Nice idea, but as I remember from this week's dev chat Twenty Twelve compatibility is to 3.1, so I think we should leave back-comp for theme options.

Agreed.

I like implementing Theme Options as a class, it make code cleaner and prefixing all the things easier.

Yes, that's why we did it.

I vote to leave this as-is.

comment:11 lancewillett21 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Discussed in IRC today to leave current behavior in place.

Note: See TracTickets for help on using tickets.