Opened 13 years ago
Closed 13 years ago
#21458 closed defect (bug) (fixed)
Label field post_title in edit-form-advanced.php missed by some screen readers
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Accessibility | Keywords: | needs-patch |
Focuses: | Cc: |
Description
In wp-admin/edit-form-advanced.php a label is added to the title field post_title like:
<label class="hide-if-no-js" style="visibility:hidden" id="title-prompt-text" for="title"><?php echo apply_filters( 'enter_title_here', __( 'Enter title here' ), $post ); ?></label>
Some screen readers omit visibility: hidden.
Maybe a solution: remove the hardcoded style="visibility:hidden" in the PHP
and add it to the css id="title-prompt-text";
Kind regards,
Rian
Attachments (3)
Change History (8)
#3
follow-up:
↓ 4
@
13 years ago
I was under impression that the issue here is the hardcoded style="visibility:hidden"
(according to the description).
DFW title doesn't have that hardcoded style (but is still controlled by wptitlehint()
JS function):
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-includes/class-wp-editor.php#L679
So I thought that 21458.patch would make it more consistent.
21458.2.patch toggles .screen-reader-text
instead (the change in wp-admin.dev.css
is to prevent .screen-reader-text
's left: -1000em
from being overridden, which causes a visual bug).
21458.3.patch is an attempt at adding aria-describedby
(not sure if that would work with style="visibility:hidden"
though).
#4
in reply to:
↑ 3
@
13 years ago
Replying to SergeyBiryukov:
Yeah, not sure whether aria-describedby
can be used with hidden element either. Sounds like it should be possible but don't know if all screenreaders would pick it.
21458.2.patch looks good, better to go with it.
This is the text that shows as a placeholder inside the title input. Moving the
visibility: hidden
to the CSS isn't going to help. Seems we have a couple options:screen-reader-text
class to hide it in a screen reader friendly mannerAlso, fullscreen/DFW will need the same treatment.