WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#21478 closed defect (bug) (fixed)

Twenty Twelve: searchform styling issues

Reported by: hd-J Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

I noticed 2 small styling issues with the searchform in Twenty Twelve:

  1. When viewing the 404 page, the searchform input field is not styled:

http://twentytwelvedemo.wordpress.com/404 http://i.wpne.ws/IZBa

Could we add similar styles than the ones applied to the sidebar searchform? http://i.wpne.ws/IYoq

  1. The submit button looks good in Safari and Chrome, but there are some padding issues in Firefox:

I did not manage to fix that 2nd problem, unfortunately, but I attached a fix for 1)

Attachments (4)

21478.diff (336 bytes) - added by hd-J 6 years ago.
Apply searchform input text rules to all searchforms
21478.2.diff (842 bytes) - added by jkudish 6 years ago.
Apply the css rules for text inputs and textareas to all input[type="text"], input[type="password"] and textarea so as to maintain a consistent look across all inputs in the theme. Simplified/removed some duplicated css in the process
21478.2.diff-screenshot.png (107.8 KB) - added by jkudish 6 years ago.
screenshot based on 21478.2.diff that shows a search text field, a comment form and input fields coming from a plugin (contact form 7 in this case)
21478.3.diff (807 bytes) - added by jkudish 6 years ago.
revised diff following r21450 - simplifies some of the css for input fields and textareas

Download all attachments as: .zip

Change History (11)

@hd-J
6 years ago

Apply searchform input text rules to all searchforms

#1 @obenland
6 years ago

Related: #21473

#2 @lancewillett
6 years ago

  • Milestone changed from Awaiting Review to 3.5

@jkudish
6 years ago

Apply the css rules for text inputs and textareas to all input[type="text"], input[type="password"] and textarea so as to maintain a consistent look across all inputs in the theme. Simplified/removed some duplicated css in the process

@jkudish
6 years ago

screenshot based on 21478.2.diff that shows a search text field, a comment form and input fields coming from a plugin (contact form 7 in this case)

#3 @jkudish
6 years ago

  • Cc joachim.kudish@… added

#4 @iandstewart
6 years ago

The patches for the first issue look good to me and the second issue should be covered in r21438.

#5 @jkudish
6 years ago

  • Keywords commit added

#6 @lancewillett
6 years ago

I think some of these styles were fixed in #21477, see r21450. Can you refresh your patch?

@jkudish
6 years ago

revised diff following r21450 - simplifies some of the css for input fields and textareas

#7 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21451]:

Twenty Twelve: fix searchform styling issues and simplify selectors even more. Fixes #21478, props hd-J and jkudish.

Note: See TracTickets for help on using tickets.