WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#21491 closed defect (bug) (fixed)

Twenty Eleven: Long URLs left in comments overflow content area

Reported by: andrewspittle's profile andrewspittle Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When posting a comment with a raw URL in the text the URL will overflow the content area for comments.

It would be best for the URL to be contained within the comment container. Using something like word-wrap: break-word; with a specific selector would work.

The screenshot attached shows this in action. See also #21151

Attachments (4)

Screen Shot 2012-08-05 at 4.41.52 PM.png​ (38.9 KB) - added by andrewspittle 13 years ago.
21491.1.diff​ (402 bytes) - added by jkudish 13 years ago.
add word-wrap: break-word to comments in Twenty Eleven
21491.2.diff​ (529 bytes) - added by jkudish 13 years ago.
revised diff following Lance's feedback regarding the proper css to use
21491.3.diff​ (533 bytes) - added by SergeyBiryukov 13 years ago.
Same as 21491.2.diff, with fixed formatting

Download all attachments as: .zip

Change History (10)

@andrewspittle
13 years ago

@jkudish
13 years ago

add word-wrap: break-word to comments in Twenty Eleven

#1 @jkudish
13 years ago

  • Cc joachim.kudish@… added

#2 @jkudish
13 years ago

  • Keywords has-patch commit added

#3 @SergeyBiryukov
13 years ago

  • Milestone changed from Awaiting Review to 3.5

#4 follow-up: @lancewillett
13 years ago

  • Keywords commit removed

See ​http://core.trac.wordpress.org/ticket/21151#comment:16 for the better CSS rules to fix this.

@jkudish
13 years ago

revised diff following Lance's feedback regarding the proper css to use

#5 in reply to: ↑ 4 @jkudish
13 years ago

Replying to lancewillett:

See ​http://core.trac.wordpress.org/ticket/21151#comment:16 for the better CSS rules to fix this.

Great (and good to know!). Revised patch in ​21491.2.diff

@SergeyBiryukov
13 years ago

Same as 21491.2.diff, with fixed formatting

#6 @lancewillett
13 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21487]:

Twenty Eleven: fix long URLs in comments overflow content area, fixes #21491. Props SergeyBiryukov jkudish andrewspittle.

Also minor pinking shears in stylesheet and functions file.

Note: See TracTickets for help on using tickets.