Opened 13 years ago
Closed 12 years ago
#21511 closed defect (bug) (fixed)
Fatal error when upgrading from older versions
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.4.2 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | Upgrade/Install | Keywords: | has-patch |
Focuses: | Cc: |
Description
Background: #18467
- If you try to upgrade from older versions (before
self_admin_url()
oresc_url()
were introduced), you'll get a fatal error due to undefined functions, even if the upgrade itself was successful.
Upgrading from 2.9:
Fatal error: Call to undefined function self_admin_url() in wp-admin/includes/update-core.php on line 698
Upgrading from 2.7:
Fatal error: Call to undefined function esc_url() in wp-admin/includes/update-core.php on line 698
- The second placeholder in line 383 doesn't contain a position specifier:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/update-core.php#L382
This results in a wrong URL:
http://releases.wordpress/2.7/wp-admin/3.4.1Which should be instead:
http://releases.wordpress/2.7/wp-admin/about.php?updated
Attachments (2)
Change History (10)
#2
@
13 years ago
We should clarify these restrictions with code comments.
This isn't a unique problem — admin-footer.php, for example, has a function_exists() call before calling get_site_option().
#3
@
13 years ago
21511.2.patch is an attempt at the comment (similar to the one in admin-footer.php
).
Note: See
TracTickets for help on using
tickets.
A relative URL (in 21511.patch) seems to work fine in my testing.