Remove 'hwstring_small' property from attachment metadata

[koopersmith]

We don't appear to use the 'hwstring_small' meta key anywhere, and as a series of html attributes, it doesn't fit in with the rest of the attachment meta keys. Thoughts on removing (and/or deprecating) it?

[nacin]

I'm fine with it vanishing. At worst, someone's image is no longer properly bound. Looks like it may not have been properly bound, anyway — it is based on an image downsize of 128 x 96, rather than any options.

Would be good to track down where it entered core and why. Sounds like it may be related to the old wp_get_attachment_thumb_file() and friends, before we had intermediate sizes.

[SergeyBiryukov]

Introduced in [2921], unused since [2958].

The patch also deprecates get_udims() (unused since [6309]), which is essentially a copy of wp_shrink_dimensions(), already deprecated in [12823]:
​http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/deprecated.php#L39

[nacin]

In [21808]:

Remove 'hwstring_small' from attachment metadata and deprecate get_udims(). props SergeyBiryukov. fixes #21518.

[SergeyBiryukov]

21518.2.patch​ corrects @return values, which are reversed:
​http://core.trac.wordpress.org/browser/tags/3.4.2/wp-includes/media.php#L278

Also adds @see/@deprecated for consistency with other functions.

[nacin]

In [21835]:

Correct return values for two deprecated media admin functions. props SergeyBiryukov. fixes #21518.

[miqrogroove]

Replying to nacin:

Would be good to track down where it entered core and why. Sounds like it may be related to the old wp_get_attachment_thumb_file() and friends, before we had intermediate sizes.

Traced it as far as https://core.trac.wordpress.org/browser/tags/2.1/wp-admin/admin-functions.php#L2112