Make WordPress Core

Opened 20 years ago

Closed 18 years ago

#2152 closed defect (bug) (wontfix)

Two search forms on one page invalidates XHTML 1.0 standards

Reported by: abhay's profile abhay Owned by: pishmishy's profile pishmishy
Milestone: Priority: normal
Severity: minor Version: 2.0
Component: General Keywords:
Focuses: Cc:

Description

Two examples:

  1. Blog with no posts causes a second search form to appear in the content area with the default Kubrick theme in addition to the search box already in the sidebar. (Although this is really trivial, I would say that this is still worth fixing.)
  1. Search yeilding no results produces two search boxes as above. This is more relevant.

Fix would be to revert to the old style where we had the "Search yielded no results" message.

Attachments (2)

2152.diff (858 bytes) - added by Nazgul 19 years ago.
2152 (662 bytes) - added by pishmishy 18 years ago.
Change default theme to only ever display one search box

Download all attachments as: .zip

Change History (12)

#1 @abhay
20 years ago

Changes would be to remove this line from wp-content/themes/default/search.php and wp-content/themes/default/index.php :

		<?php include (TEMPLATEPATH . '/searchform.php'); ?>

@Nazgul
19 years ago

#2 @Nazgul
19 years ago

  • Keywords has-patch added

#3 @matt
19 years ago

  • Milestone changed from 2.1 to 2.2

#4 follow-up: @foolswisdom
19 years ago

  • Keywords has-patch removed
  • Milestone changed from 2.2 to 2.4

I don't like this fix. Many themes duplicate this style of providing a search box when no results are found, without having to find it in the sidebar.

#5 in reply to: ↑ 4 ; follow-up: @Nazgul
18 years ago

Replying to foolswisdom:

I don't like this fix. Many themes duplicate this style of providing a search box when no results are found, without having to find it in the sidebar.

What other options are there when you're only allowed to have 1 form on a page?

#6 in reply to: ↑ 5 @foolswisdom
18 years ago

Replying to Nazgul:

What other options are there when you're only allowed to have 1 form on a page?

Showing a search box when no results is a common experience, so the solution should account for that.

#7 @foolswisdom
18 years ago

  • Milestone changed from 2.4 to 2.5

#8 @pishmishy
18 years ago

  • Owner changed from anonymous to pishmishy
  • Status changed from new to assigned

Personally I don't think that the default theme should ever display more than one search box on any page. It's unnecessary interface clutter.

If the appearance of the side bar never changed between pages throughout the theme I could accept an argument for leaving it for reasons of consistency. But that doesn't appear to be the case.

Patching the theme so that the sidebar search box has a different name is trivial if that turns out to be the preferred option.

Neither change effects what authors of other themes want to do.

@pishmishy
18 years ago

Change default theme to only ever display one search box

#9 @pishmishy
18 years ago

  • Component changed from Administration to General

With no feedback, only displaying a single search box is my preferred option and I've attached a patch to do this with the default theme.

#10 @pishmishy
18 years ago

  • Milestone 2.6 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Still no feed back so as much as I'd like to see this issue resolved, closing as WONTFIX. Authors of themes are free to fix this problem as they please.

Note: See TracTickets for help on using tickets.