post_type_supports(), no arguments case

[bilalcoder]

At line 1388 in wp-includes/post.php when checking for number of arguments passed to post_type_supports():

if( function_num_args() <= 2 )

return true;

Obviously it does not hurt, but absolutely it's just an extra code.

[SergeyBiryukov]

Looking at the code (introduced in [12682]), seems that the check can be removed indeed:
​http://core.trac.wordpress.org/browser/tags/3.4.1/wp-includes/post.php#L1358

Related: #17584

[SergeyBiryukov]

Looks like remove_post_type_support() can lose some redundant code too, the second isset() check is unnecessary: 21527.2.diff​.

[obenland]

I know returning early is a popular coding convention in core, but why not just say:

<?php

if ( isset( $_wp_post_type_features[$post_type] ) )
    unset( $_wp_post_type_features[$post_type][$feature] );

[SergeyBiryukov]

In 23722:

Remove redundant code from post_type_supports() and remove_post_type_support(). props obenland, bilalcoder. fixes #21527.

[nacin]

Replying to obenland:

I know returning early is a popular coding convention in core, but why not just say:

<?php

if ( isset( $_wp_post_type_features[$post_type] ) )
    unset( $_wp_post_type_features[$post_type][$feature] );

Even the isset() here is unnecessary. :-)