Error suppression in wp-db is lame: Part 2

[Viper007Bond]

Previously: #15402

This was fixed in [16321] however that was built upon [16320] and both were reverted in [16336] because it "Breaks things". What things it breaks I have no idea though (bad westi for not using a better commit message ;)). However I assume it was [16320] that broke things and not [16321].

[16321] seems perfectly valid to me and we should re-apply it along with a fix to __get() that throws a warning when $result isn't set yet.

[SergeyBiryukov]

Since [21472], I get errors in Debug Bar:

WARNING: wp-includes/wp-db.php:1079 - mysql_free_result(): supplied argument is not a valid MySQL result resource

Moved to wpdb::flush(), mysql_free_result() now runs earlier than $this->result is set:
​http://core.trac.wordpress.org/browser/trunk/wp-includes/wp-db.php?rev=21473#L1138

21533.patch​ fixes the warning.

[westi]

From memory what this broke was HyperDB on WP.org

[Viper007Bond]

Replying to westi:

From memory what this broke was HyperDB on WP.org

Checking if it was a resource was what broke it? Crazy...

[SergeyBiryukov]

Replying to Viper007Bond:

Checking if it was a resource was what broke it? Crazy...

I guess westi was referring to [16320].

[kurtpayne]

Updated with test for get too

[kurtpayne]

Unit test added. It functions the same way as debug bar -- by spying on the error handler.

[SergeyBiryukov]

Closed #21574 as a duplicate.

[scribu]

I now get this notice on every admin page in trunk:

WARNING: wp-includes/wp-db.php:1079 - mysql_free_result() expects parameter 1 to be resource, boolean given

[Viper007Bond]

Replying to scribu:

I now get this notice on every admin page in trunk:

Yep, this is why this ticket was opened. See above. ;)

[nacin]

[21511]

[nacin]

In [21513]:

@since for wpdb's result property. props SergeyBiryukov. see #21533.