Make WordPress Core

Opened 21 months ago

Last modified 3 months ago

#21546 new enhancement

Site Settings page is a hot mess

Reported by: wonderboymusic Owned by:
Milestone: Future Release Priority: low
Severity: minor Version: 3.0
Component: Options, Meta APIs Keywords: needs-patch
Focuses: multisite Cc:


I found out just how bad this page is when debugging an issue related to WPLANG. WPLANG is an option for a blog in your network (overrides WPLANG in wp-config.php), but if you delete the option on purpose or accidentally, there is no way of restoring it in the admin.

Site Settings just loads your options table and POSTs back to itself. The only reference to the original options map (the defaults) is in schema, which WP has zero access to outside of upgrade.

I have abstracted the default options and the default "fat" options into functions in ms.php. Also, when loading your Site Settings options - if a default option is missing, I display it in the admin so you can save it (it is populated with its default value).

I have also streamlined and condensed some code that was happening in and around populate_options()

Attachments (1)

site-settings.diff (21.5 KB) - added by wonderboymusic 21 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Mamaduka20 months ago

  • Cc georgemamadashvili@… added

comment:2 nacin20 months ago

populate_options() isn't just used for multisite — it's for the initial install, too.

comment:3 jeremyfelt3 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

Moving to future release, as site settings wouldn't hurt from some attention.

Per @nacin's populate_options() note, that part of the patch should be rethought.

comment:4 jeremyfelt3 months ago

  • Component changed from Multisite to Options and Meta
  • Focuses multisite added
Note: See TracTickets for help on using tickets.