Make WordPress Core

Opened 12 years ago

Last modified 5 years ago

#21546 reopened enhancement

Site Settings page is a hot mess

Reported by: wonderboymusic's profile wonderboymusic Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Options, Meta APIs Keywords: needs-patch needs-testing
Focuses: multisite Cc:


I found out just how bad this page is when debugging an issue related to WPLANG. WPLANG is an option for a blog in your network (overrides WPLANG in wp-config.php), but if you delete the option on purpose or accidentally, there is no way of restoring it in the admin.

Site Settings just loads your options table and POSTs back to itself. The only reference to the original options map (the defaults) is in schema, which WP has zero access to outside of upgrade.

I have abstracted the default options and the default "fat" options into functions in ms.php. Also, when loading your Site Settings options - if a default option is missing, I display it in the admin so you can save it (it is populated with its default value).

I have also streamlined and condensed some code that was happening in and around populate_options()

Attachments (1)

site-settings.diff (21.5 KB) - added by wonderboymusic 12 years ago.

Download all attachments as: .zip

Change History (8)

#1 @Mamaduka
12 years ago

  • Cc georgemamadashvili@… added

#2 @nacin
12 years ago

populate_options() isn't just used for multisite — it's for the initial install, too.

#3 @jeremyfelt
10 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

Moving to future release, as site settings wouldn't hurt from some attention.

Per @nacin's populate_options() note, that part of the patch should be rethought.

#4 @jeremyfelt
10 years ago

  • Component changed from Multisite to Options and Meta
  • Focuses multisite added

#5 @chriscct7
9 years ago

  • Milestone Future Release deleted
  • Priority changed from low to normal
  • Resolution set to maybelater
  • Severity changed from minor to normal
  • Status changed from new to closed

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 3 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch).

#6 @jeremyfelt
9 years ago

  • Keywords needs-testing added
  • Milestone set to Future Release
  • Resolution maybelater deleted
  • Status changed from closed to reopened

Site settings is still a hot mess. I'd like to keep this ticket open for additional testing and possible alternative patches. I'll take a closer look at the patch attached to this as well.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.

8 years ago

Note: See TracTickets for help on using tickets.