WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21582 closed defect (bug) (fixed)

Correct @since values for wpdb properties

Reported by: SergeyBiryukov Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

$num_rowsexisted in 0.71, declared as var in [13314] (3.0)
$last_queryexisted in 0.71, declared as var in [1180] (1.2)
$last_resultexisted in 0.71, declared as var in [13314] (3.0)
$col_infoexisted in 0.71, declared as var in [1180] (1.2)
$prefixintroduced in [6300] (2.5.0)
$readyintroduced in [6459] (2.3.2)
$dbpasswordintroduced in [15537] (3.1), declared as protected in [21473] (3.5)
$dbnameintroduced in [15537] (3.1), declared as protected in [21473] (3.5)
$dbhostintroduced in [15537] (3.1), declared as protected in [21473] (3.5)
$dbhexisted in 0.71, declared as protected in [21473] (3.5)

Attachments (2)

21582.patch (1.7 KB) - added by SergeyBiryukov 3 years ago.
21582.2.patch (1.7 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

comment:1 @SergeyBiryukov3 years ago

21582.2.patch also updates $last_query description, which appears to be inaccurate.

comment:2 @SergeyBiryukov3 years ago

Should @since reflect when a property first appeared, or when it was declared?
There's currently some inconsistency, but I've assumed the former.

comment:3 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21521]:

Update @since for various wpdb properties. Props SergeyBiryukov. fixes #21582

Note: See TracTickets for help on using tickets.