Context Navigation

← Previous Ticket
Next Ticket →

#21593 closed defect (bug) (fixed)

register_taxonomy() doesn't fail when taxonomy name too long

Reported by:	psbook	Owned by:	ryan
Priority:	normal	Milestone:	3.5
Component:	Taxonomy	Version:	3.4.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description (last modified by nacin)

The 'taxonomy' field of the 'term_taxonomy' table is VARCHAR(32), ie truncated at 32 characters. But register_taxonomy() doesn't fail when you try to create a taxonomy with a unique name longer than this.

The effects are that terms can be added to 'terms' table along with corresponding entries in 'term_taxonomy', but that these can't be read back again. The taxonomy appears in the admin menus, but appears to be totally empty.

Attachments (1)

21593.patch (1.6 KB ) - added by ocean90 14 years ago.

Download all attachments as: .zip

Change History (8)

#1 @nacin
14 years ago

Description modified (diff)
Summary create_taxonomy() doesn't fail when taxonomy name too long → register_taxonomy() doesn't fail when taxonomy name too long

In register_post_type(), we do:

if ( strlen( $post_type ) > 20 )
		return new WP_Error( 'post_type_too_long', __( 'Post types cannot exceed 20 characters in length' ) );

Seems like a good thing here.

@ocean90
14 years ago

Attachment 21593.patch added

#2 @ocean90
14 years ago

Keywords has-patch added
Milestone Awaiting Review → 3.5

#3 @ocean90
14 years ago

Related: #21600

#4 @ryan
14 years ago

We need to make sure sanitize_key() doesn't trip over 'attachment:' taxonomy strings, otherwise looks good.

#5 @ryan
14 years ago

Owner set to ryan
Resolution → fixed
Status new → closed

In [22307]:

Return WP_Error when registering a taxonomy that exceeds 32 characters.

Props ocean90.
fixes #21593

#6 @ryan
14 years ago

[UT1095]

#7 @duck_
14 years ago

In [22309]:

Fix documentation typo: s/WP_Erorr/WP_Error/. See #21593.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#21593 closed defect (bug) (fixed)

register_taxonomy() doesn't fail when taxonomy name too long

Description (last modified by nacin)

Attachments (1)

Change History (8)

#1 @nacin 14 years ago

@ocean90 14 years ago

#2 @ocean90 14 years ago

#3 @ocean90 14 years ago

#4 @ryan 14 years ago

#5 @ryan 14 years ago

#6 @ryan 14 years ago

#7 @duck_ 14 years ago