redirect_canonical can lead to infinite loop on index navigation if site url is not all lower case
|Reported by:||sreedoap||Owned by:|
|Component:||Canonical||Keywords:||needs-unit-tests has-patch 4.6-early|
The function redirect_canonical in wp-includes/canonical.php (WordPress 3.4.1) on line 406 and 422 makes the following check:
if ( !$redirect_url || $redirect_url == $requested_url ) return false;
This ensures that it does not attempt to redirect you to the page you requested in the first place. However this function is not case sensitive so if the redirect URL is in a different case than the requested URL then the user can enter an infinite redirect loop. (For example if the Site Address (URL) of the site is set to be in all upper case.)
This function should do a case-insensitive string comparison since domain names are case-insensitive.
The issue only appears to happen with certain plugins installed (ShareThis and PilotPress both led to this issue,) I haven't figured out yet why it's only an issue with certain plugins but it should still be fixed in WordPress to make the proper string comparison.
Change History (38)
- Milestone changed from 4.4.2 to 4.5
- Resolution fixed deleted
- Status changed from closed to reopened