WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#21609 closed defect (bug) (fixed)

Duplicate comments should be allowed under different comment_parent

Reported by: andy Owned by: nacin
Priority: normal Milestone: 3.5
Component: Comments Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Scenario: A post has several top-level comments. A user treating these as tasks wishes to mark them done by replying to each comment, "Done." The user is forced to vary the "done" reply each time.

Duplicate comment detection prevents accidental re-submission. When comment_parent differs, this probably indicates the user's intention to post the same comment a second time.

Attachments (2)

21609.patch​ (875 bytes ) - added by andy 14 years ago.
Add comment_parent to duplicate comment check
21609.2.patch​ (1.2 KB ) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (9)

@andy
14 years ago

Add comment_parent to duplicate comment check

#1 @andy
14 years ago

  • Keywords has-patch added

#2 @scribu
14 years ago

I could have sworn I opened a similar ticket some years ago.

#3 @SergeyBiryukov
14 years ago

Related: #9775 (which wasn't actually fixed in [13434] as ticket:9775:12 assumed, since there's still no way to get around the check).

#4 @nacin
14 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.5

I know these values are "safe" but it would be nice if we also prepared these queries.

@SergeyBiryukov
14 years ago

#5 @SergeyBiryukov
14 years ago

21609.2.patch​ prepares the queries.

#6 @nacin
14 years ago

Since these values are slashed we would need to unslash to prepare. Going to avoid that for now.

#7 @nacin
14 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In [22229]:

Duplicate comments should be allowed under a different comment parent. props andy. fixes #21609.

Note: See TracTickets for help on using tickets.