Changes between Version 1 and Version 2 of Ticket #21613, comment 3
- Timestamp:
- 08/17/2012 03:31:39 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #21613, comment 3
v1 v2 7 7 > Current behaviour appears to be proper. 8 8 9 Well, the code comment was recently updated to reflect the fact that the behavior is backwards( 'Whether the $content should pass through htmlspecialchars().' has become 'Whether the $content should NOT pass through htmlspecialchars().'). I'm not sure the variable name $richedit makes sense anymore...perhaps $dont_encode = false would make more sense. Either way, having a variable that a) isn't really descriptive and b) written as a double negative is probably not ideal for clarity.9 Well, the code comment was recently updated (between v 3.3.3 and 3.4) to reflect the fact that the behavior is backwards( 'Whether the $content should pass through htmlspecialchars().' has become 'Whether the $content should NOT pass through htmlspecialchars().'). I'm not sure the variable name $richedit makes sense anymore...perhaps $dont_encode = false would make more sense. Either way, having a variable that a) isn't really descriptive and b) written as a double negative is probably not ideal for clarity.