WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#21614 closed defect (bug) (duplicate)

wp_mime_type_icon PHP notice fixes

Reported by: sc0ttkclark Owned by:
Milestone: Priority: normal
Severity: trivial Version: 3.4.1
Component: Warnings/Notices Keywords:
Focuses: Cc:

Description

wp_mime_type_icon ends up sending to the 'wp_mime_type_icon' filter: $icon, $mime, and $post_id

Based on the PHP, it's set in such a way that PHP notices could be generated for variables don't exist.

I've attached my patch that should resolve those potential notices.

Attachments (1)

21615.patch (580 bytes) - added by sc0ttkclark 5 years ago.

Download all attachments as: .zip

Change History (6)

@sc0ttkclark
5 years ago

#1 @sc0ttkclark
5 years ago

Oops, missed it by one number, pretend my patch was really 21614.patch :)

#2 @SergeyBiryukov
5 years ago

  • Component changed from Media to Warnings/Notices
  • Milestone changed from Awaiting Review to 3.5

#3 @nacin
5 years ago

  • Milestone 3.5 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #21828.

#4 @sc0ttkclark
5 years ago

This ticket was duplicated by #21835 (partially), but committed as part of the patch that went in for it. (just noting here for reference)

#5 @sc0ttkclark
5 years ago

  • Keywords has-patch dev-feedback removed
Note: See TracTickets for help on using tickets.