Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #21652, comment 3


Ignore:
Timestamp:
02/23/2014 12:35:33 PM (12 years ago)
Author:
ocean90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21652, comment 3

    initial v1  
    33I agree, the error handling can be improved here. Since we already returning WP_Error objects we easily can add one more, so the change is backward compatible.
    44
    5 We're doing similar checks on other places, like `wp_insert_term()` or `is_object_in_term()`, where we just declare the input as invalid. In [attachment:21652.2.patch] I have used a similar phrase. It changes also the operator of the first check, which was missed in 21652.patch.
     5We're doing similar checks on other places, like `wp_insert_term()` or `is_object_in_term()`, where we just declare the input as invalid. In [attachment:21652.2.patch] I have used a similar phrase.