Incorrect URL For Theme Options With Custom Post Type

[jarretc]

Steps to reproduce:

1. Register a custom post type or any other item that gets added to the Options menu under Appearance->Themes(themes.php)
2. Set CPT show_in_menu value to themes.php or require capability edit_theme_options
3. View link in Appearance->Themes(themes.php) under the Options row for current active theme

Patch adds a check to see if edit_theme_options is used and if not, then remove the themes.php?page= that gets added to the URL.

[SergeyBiryukov]

Couldn't reproduce on a clean install with Twenty Twelve.

My steps:

1. Created the post type:

   register_post_type( 'test', array(
   	'label' => 'Test',
   	'public' => true, 
   	'show_in_menu' => 'themes.php',
   	'capability_type' => 'post',
   ) );
   

2. The URL under Appearance → Test is correct:

   http://trunk.wordpress/wp-admin/edit.php?post_type=test
   

3. Twenty Twelve's Theme Options URL is also correct:

   http://trunk.wordpress/wp-admin/themes.php?page=theme_options
   

If I set capability_type to 'edit_theme_options', Appearance → Test item doesn't appear at all, Twenty Twelve's Theme Options URL is still correct.

Is there anything I'm missing? Could you paste the code that causes the issue?

[JarretC]

This doesn't have anything to do with the Appearance->Test URL. It has to do with the URL on the Appearance->Themes page.

See attached screenshot for the area I'm referring to.

This is the exact code that I have in Twentytwelve functions.php...

function jarret_test() {
register_post_type( 'test', array(
	'label' => 'Test',
	'public' => true,
	'show_in_menu' => 'themes.php',
	) );
}
add_action('init', 'jarret_test');

[SergeyBiryukov]

Ah, I see. Another option (implemented in 21655.patch​) would probably be to check if the parent file exists, like we already do in several places in menu-header.php:
​http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/menu-header.php#L96

[JarretC]

Ok, well you know way more than I do so I'm sure that your patch will/does cover a lot more cases than mine.

[nacin]

21655.patch​ appears good.

[ryan]

In [21969]:

Fix CPT links in Theme Options list. Props SergeyBiryukov, JarretC. fixes #21655