WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #21668, comment 29


Ignore:
Timestamp:
01/23/2014 04:59:24 PM (7 years ago)
Author:
buley
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21668, comment 29

    v2 v3  
    1 For the sake of a more performant Internet, saving images as progressive when possible is a default option that I hope WordPress adopts.
     1For the sake of a more (apparently) performant Internet, saving images as progressive when possible is a default option that I hope WordPress adopts.
    22
    33At parade.com we used 21668.4.patch for several months on the WP3.5 branch (https://core.trac.wordpress.org/attachment/ticket/21668/21668.4.patch). The improvements in 21668.5.patch (https://core.trac.wordpress.org/attachment/ticket/21668/21668.5.patch ) are nice - allowing filter-based control - but I think the default `false` option is the wrong one for the Web. The changes in 21668.6 (https://core.trac.wordpress.org/attachment/ticket/21668/21668.6.patch ) seem more complex than required and are to me confusing, especially since it appears to be wrongly checking for a "PNG" mimetype when the $mimetype (correctly) is "image/png".