WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#21675 closed enhancement (fixed)

Twenty Twelve: review and clarify code comments

Reported by: jorbin Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: trivial Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Some functions are mis documented and others could be a bit more verbose

Attachments (7)

2012docs.diff (2.7 KB) - added by jorbin 9 years ago.
21675.diff (17.9 KB) - added by obenland 9 years ago.
twentytwelve-archives.diff (5.7 KB) - added by DrewAPicture 9 years ago.
twentytwelve-content.diff (10.6 KB) - added by DrewAPicture 9 years ago.
twentytwelve-head-foot-side.diff (5.8 KB) - added by DrewAPicture 9 years ago.
twentytwelve-misc.diff (8.9 KB) - added by DrewAPicture 9 years ago.
twentytwelve-templates.diff (1.5 KB) - added by DrewAPicture 9 years ago.

Download all attachments as: .zip

Change History (13)

@jorbin
9 years ago

#1 @lancewillett
9 years ago

  • Owner set to lancewillett
  • Status changed from new to accepted
  • Summary changed from The documentation in twentytwelve needs a bit of clarification to Twenty Twelve: review and clarify code comments

Thanks—will review and get the clarifications in. Except maybe the anteater comment. :)

@obenland
9 years ago

#2 @lancewillett
9 years ago

  • Priority changed from low to normal

#3 @lancewillett
9 years ago

In [21617]:

Twenty Twelve: review and clarify code commenting and documentation. Props jorbin and obenland. See #21675.

#4 @lancewillett
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [21618]:

Twenty Twelve: review and clean up end-of-element HTML comments. Props obenland for starter patch. Closes #21675.

#5 @DrewAPicture
9 years ago

  • Cc xoodrew@… added
  • Resolution fixed deleted
  • Status changed from closed to reopened

I've attached some cleanup diffs for consideration per @lancewillett's go-ahead. A great deal of this is spacing out blocks of markup and code so it's more readable and easier to follow. Mixed in are several missing end-of-element HTML comments and a couple of typo/grammar fixes. I've grouped the changes into multiple diffs so it's easier to take or leave some but not all.

#6 @DrewAPicture
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Re-closing as fixed.

Note: See TracTickets for help on using tickets.