Twenty Twelve: Small navigation not showing with JS off

[Jayjdk]

When a user browses with javascript turned off and with a browser width < 600px, there's no way to see the navigation.

My suggestion would be to add a no-js class to the html/body tag as the dashboard does.

When use CSS to show the navigation and hide the button:

.no-js .main-navigation ul.nav-menu {
   display: block;
}

.no-js .menu-toggle {
  display: none;
}

The code used in the dashboard to do it is:

document.body.className = document.body.className.replace('no-js','js');

[Jayjdk]

Adds no-js to the body tag

[lancewillett]

Great suggestion, thanks for the report and patch.

[lancewillett]

I'm going to work on this, but probably in a week or two after we release to WP.com and Extend and let the dust settle there a bit.

[lancewillett]

Refreshed patch with a bit of commenting

[lancewillett]

Discussing today in IRC, seems on one hand to be overkill for a theme to be doing this kind of checking.

But, if the amount of visitors affected ( < 600px and no JS ) is an appreciable and quantifiable amount, I can see the argument to include it.

Not sure if those same user agents (mobile devices) would also have CSS support.

[Jayjdk]

Yeah, you're properly right; it will affect very few users. Hopefully we'll be able to ​detect it with CSS in the future.

Should this ticket be closed or stay open?

[lancewillett]

Replying to Jayjdk:

Yeah, you're properly right; it will affect very few users. Hopefully we'll be able to ​detect it with CSS in the future.

Should this ticket be closed or stay open?

Let's leave it open, Nacin wanted to do some more research on it. I think we're mostly leaning in the close as wontfix direction.

[lancewillett]

@nacin — Did you have a chance to look at this one again?

[lancewillett]

Feel free to re-open later if we need to take another look at this.