WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 12 months ago

#21712 closed enhancement (fixed)

Enhancements to wp-signup.php and wp-activate.php

Reported by: geminorum Owned by: jeremyfelt
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.4.1
Component: Login and Registration Keywords: needs-patch dev-feedback
Focuses: template, multisite Cc:

Description

While #17948 going on, I suggest calling get_header()/get_footer() along with 'singnup'/'activate' parameter on wp-signup.php and wp-activate.php.
Something like:

get_header( 'signup' );
get_footer( 'activate' );

Also adding before_activate_form and after_activate_form action hooks into wp-activate.php just like wp-signup.php

Change History (7)

#1 @jeremyfelt
3 years ago

  • Severity changed from minor to normal

Related: #20075 addresses the requested action hooks

#2 @nacin
3 years ago

  • Component changed from Template to Login and Registration
  • Focuses template multisite added

#3 @chriscct7
12 months ago

  • Keywords needs-patch added
  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 2 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)

#4 follow-up: @jeremyfelt
12 months ago

  • Keywords dev-feedback added
  • Milestone set to 4.4
  • Resolution maybelater deleted
  • Status changed from closed to reopened

I was wondering about this same thing when digging into #17630 the other day. It seems like adding context to get_header() and get_footer() makes sense. I'm going to move this to 4.4 so we can say yes or close it for good. :)

  • Should this argument be wp-activate and wp-signup so that we don't accidentally load custom headers previously created for something else?
  • Is there any reason not to introduce this change?

#5 @jeremyfelt
12 months ago

  • Owner set to jeremyfelt
  • Status changed from reopened to assigned

#6 in reply to: ↑ 4 @obenland
12 months ago

Replying to jeremyfelt:

Should this argument be wp-activate and wp-signup so that we don't accidentally load custom headers previously created for something else?

I think that's a good idea.

Is there any reason not to introduce this change?

I think it's a good change!

#7 @jeremyfelt
12 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34840:

MS: Pass context to get_header() and get_footer() in activation/signup.

Fixes #21712.

Note: See TracTickets for help on using tickets.